Differential D5982

cypress/layout: Fix cypress anti-pattern use
ClosedPublic
Actions

Authored by anlambert on Jul 8 2021, 7:09 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPSa9688b3a9818: cypress/layout: Fix cypress anti-pattern use

Summary

Cypress commands should not be invoked in a loop as it is an anti-pattern
that can produce flaky tests.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jul 8 2021, 7:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 8 2021, 7:09 PM

Build is green

Patch application report for D5982 (id=21563)

Rebasing onto 25c639f292...

Current branch diff-target is up to date.

Changes applied before test

commit a9688b3a981847d71c56e340c25f743c94a8d85a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Jul 8 19:08:14 2021 +0200

    cypress/layout: Fix cypress anti-pattern use
    
    Cypress commands should not be invoked in a loop as it is an anti-pattern
    that can produce flaky tests.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/957/ for more details.

Harbormaster completed remote builds in B22537: Diff 21563.Jul 8 2021, 7:24 PM

anlambert requested review of this revision.Jul 8 2021, 7:24 PM

anlambert added a child revision: D5969: templates/snapshot-context: Visit origin URL in a new browser tab.Jul 8 2021, 7:36 PM

lgtm

cypress/integration/layout.spec.js
185	I guess those calls could have been made in a loop though, right? (just asking out of curiosity, not asking you to change anything ;)

This revision is now accepted and ready to land.Jul 9 2021, 11:50 AM

anlambert added inline comments.Jul 9 2021, 12:19 PM

cypress/integration/layout.spec.js
185	The thing is that we can't use for loops with cypress because of its async nature. Cypress doesn't wait for everything to complete in the loop before starting the loop again.