If each method needs to call statsd, what are the returns for?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Mar 3 2020
Mar 3 2020
vlorentz requested changes to D2759: indexer.storage: Make add/del endpoints sum up added objects count.
vlorentz updated subscribers of D2757: Add a flag to copy objects only if they don't exist in the destination.
In D2757#65748, @olasd wrote:That's not an either/or affair IMO. By definition as long as the replayer is running, the exclusion file is always out of date (and updating it is quite costly).
vlorentz committed rDSNIPacf8045b6d31: Add script and instructions to generate the objstorage replay exclusion file. (authored by vlorentz).
Add script and instructions to generate the objstorage replay exclusion file.
vlorentz added a comment to D2757: Add a flag to copy objects only if they don't exist in the destination.
What about updating the exclusion file instead?
vlorentz added inline comments to D2742: Add classmethod Person.from_address, to parse from 'name <email>' strings..
We probably want to keep svn_author_to_swh_person, as it deals with the None case. As for convert_commit_author, I just kept it as is, but probably not.
In D2743#65674, @olasd wrote:I'm surprised that this change doesn't incur a change of the id some of the tested revisions (e.g. in the npm case).
This is something that we should probably cover better.
Mar 2 2020
Mar 2 2020
nice!
wait, so that contextmanager didn't work at all?
vlorentz committed rDENVc22e4abac4ff: Remove validating proxy from the storage pipeline for loaders. (authored by vlorentz).
Remove validating proxy from the storage pipeline for loaders.
nice!
Feb 28 2020
Feb 28 2020
vlorentz committed rDLDGdf69b7e0f760: Use swh-model objects instead of dicts. (authored by vlorentz).
Use swh-model objects instead of dicts.
vlorentz committed rDLDGf2a0736f42e9: Use origin_visit_get_latest instead of snapshot_get_latest. (authored by vlorentz).
Use origin_visit_get_latest instead of snapshot_get_latest.
vlorentz committed rDLDBASE43728c596498: Use swh-model objects in base VCS loader. (authored by vlorentz).
Use swh-model objects in base VCS loader.
vlorentz committed rDSTO522235252687: Use Content.hashes() instead of Content.to_dict() where it makes sense. (authored by vlorentz).
Use Content.hashes() instead of Content.to_dict() where it makes sense.
vlorentz committed rDSTOd096542f8fae: Make the RPC client and objstorage helper fetch Content.data. (authored by vlorentz).
Make the RPC client and objstorage helper fetch Content.data.
vlorentz committed rDSTO3996e5df147c: Move ctime out of the validation proxy. (authored by vlorentz).
Move ctime out of the validation proxy.
vlorentz committed rDCORE041728f8e4c9: Allow subclasses of RPCClient to override methods. (authored by vlorentz).
Allow subclasses of RPCClient to override methods.
add test
vlorentz added a comment to D2685: test_storage: Fix some RPC tests after recent changes in swh-core.
Replaced by D2690
caf51a044377cf62f73a02cd6c641d94b4e32c95
Feb 27 2020
Feb 27 2020
vlorentz committed rDLDBASE0c58f98ef1df: Use swh-model objects in package loader. (authored by vlorentz).
Use swh-model objects in package loader.
Accept cassandra-driver >= 3.22.
remove prints
It's still missing a description of what it does (ie. check that files exist in swh), in the CLI help and/or README.
vlorentz committed rDMODf7f18a3f2b71: Make attributes name and email of Person optional. (authored by vlorentz).
Make attributes name and email of Person optional.
vlorentz committed rDMOD750d147131ba: Add from_datetime and from_iso8601 constructors for TimestampWithTimezone. (authored by vlorentz).
Add from_datetime and from_iso8601 constructors for TimestampWithTimezone.
vlorentz committed rDMOD9cf7a04a3e0c: Add method MerkleNode.iter_tree, to visit all nodes in the subtree of a node. (authored by vlorentz).
Add method MerkleNode.iter_tree, to visit all nodes in the subtree of a node.
vlorentz committed rDMODc0ce38ed4948: Take the value of MerkleNode.data into account to compute equality. (authored by vlorentz).
Take the value of MerkleNode.data into account to compute equality.
vlorentz updated the diff for D2720: Add from_datetime and from_iso8601 constructors for TimestampWithTimezone..
fix base
vlorentz updated the diff for D2720: Add from_datetime and from_iso8601 constructors for TimestampWithTimezone..
comments
Make build_revision return Revision objects instead of dicts.
vlorentz updated the diff for D2720: Add from_datetime and from_iso8601 constructors for TimestampWithTimezone..
add test + negative utc
vlorentz updated the diff for D2713: Add method MerkleNode.iter_tree, to visit all nodes in the subtree of a node..
apply comments
Also, compute_hash is a staticmethod that takes a dict as argument.
Oh, I forgot about compute_hash. And also that the id is "optional" (well not optional, but can be set to b'')
Feb 26 2020
Feb 26 2020
vlorentz requested changes to D2718: JournalClient: add a stop_at_eof boolean to read the log only once.
Feb 25 2020
Feb 25 2020
although you should change the commit message: "The full contents of the journal" -> "The existing contents of the journal"
Perfect, thanks!
Feb 24 2020
Feb 24 2020
remove print
vlorentz committed rDMOD6da524cb2bd8: Add to_model() method to from_disk.{Content,Directory}, to convert to canonical… (authored by vlorentz).
Add to_model() method to from_disk.{Content,Directory}, to convert to canonical…
vlorentz updated the diff for D2703: Add to_model() method to from_disk.{Content,Directory}, to convert to canonical model objects..
apply comment
Fix tests of special devices.
vlorentz committed rDLDBASE384f1d302f95: Move revision loading logic to its own function. (authored by vlorentz).
Move revision loading logic to its own function.