Page MenuHomeSoftware Heritage
Differential D2731

Use swh-model objects instead of dicts.
ClosedPublic
Actions

Authored by vlorentz on Feb 28 2020, 1:42 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDLDGdf69b7e0f760: Use swh-model objects instead of dicts.
Test Plan

tests will fail because D2730 is needed

Diff Detail

Repository
rDLDG Git loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 28 2020, 1:42 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 28 2020, 1:42 PM
Harbormaster failed remote builds in B10803: Diff 9736!Feb 28 2020, 1:42 PM
swh-public-ci added a comment.Feb 28 2020, 1:42 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/113/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/113/console

ardumont accepted this revision.Feb 28 2020, 1:52 PM
This revision is now accepted and ready to land.Feb 28 2020, 1:52 PM
swh-public-ci added a comment.Feb 28 2020, 5:19 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/114/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/114/console

vlorentz added a parent revision: D2729: Use origin_visit_get_latest instead of snapshot_get_latest..Feb 28 2020, 5:24 PM
swh-public-ci added a comment.Feb 28 2020, 5:25 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/115/ for more details.

Harbormaster completed remote builds in B10803: Diff 9736.Feb 28 2020, 5:25 PM
Closed by commit rDLDGdf69b7e0f760: Use swh-model objects instead of dicts. (authored by vlorentz). · Explain WhyFeb 28 2020, 5:30 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDLDGdf69b7e0f760: Use swh-model objects instead of dicts..

Revision Contents
Changeset List

PathSize
swh/
loader/
git/
210 lines
39 lines
95 lines
tests/
3 lines
284 lines

Diff 9755

View Options

swh/loader/git/converters.py

Loading...
View Options

swh/loader/git/from_disk.py

Loading...
View Options

swh/loader/git/loader.py

Loading...
View Options

swh/loader/git/tests/__init__.py

Loading...
View Options

swh/loader/git/tests/test_converters.py

Loading...
About · Developer information · Legal