refactor diff to defer loading content data after creating content object.
Fri, Feb 21
Add missing hunk
Looks good to me, thanks!
use git order
Thu, Feb 20
We already have lots of issues with loaders having an "optimistic" usage of memory, so I'd be tempted to introduce a DiskBackedContent (DiskContent?) model, inheriting from Content, with a path attribute as well as a lazy data attribute that will read data from disk the first time it's accessed.
What's the difference?
The difference between what and what?
add doc for max_content_length.
That'd be a lot more work downstream, but wouldn't it make sense to have get_data return model objects directly instead of dicts?
By default, from_disk will not pull the full data from disk into memory, so by doing this there's a good chance you'll end up with a Content object that has an empty data attribute.
That explain the inconsistent behavior I noticed in tenacity... thanks!
I see you did not annotate some of the functions. Do you need help with those?
Wed, Feb 19
update commit message to mention swh-scheduler
But then, errors would pass silently...
Tue, Feb 18
Shouldn't the new test be in a new tests module?
I guess we should have the RPC client/server pair re-raise ValueErrors? @vlorentz?
change base commit