Page MenuHomeSoftware Heritage
Feed Advanced Search

Today

vlorentz accepted D2708: pre-commit: Add eslint hook for javascript files.
Sun, Feb 23, 10:04 AM

Yesterday

vlorentz edited projects for T2268: Add a CLI tool to ease the retrieval of authentication tokens , added: Web app; removed Restricted Project.
Sat, Feb 22, 6:07 PM · Web app

Fri, Feb 21

vlorentz updated the diff for D2703: Add to_model() method to from_disk.{Content,Directory}, to convert to canonical model objects..

refactor diff to defer loading content data after creating content object.

Fri, Feb 21, 4:35 PM
vlorentz updated the diff for D2706: Fix tests of special devices..

apply comment

Fri, Feb 21, 4:03 PM
vlorentz updated the diff for D2706: Fix tests of special devices..

Add missing hunk

Fri, Feb 21, 3:59 PM
vlorentz created D2706: Fix tests of special devices..
Fri, Feb 21, 3:57 PM
vlorentz planned changes to D2703: Add to_model() method to from_disk.{Content,Directory}, to convert to canonical model objects..
Fri, Feb 21, 1:39 PM
vlorentz closed D2702: Sort from_disk.Directory entries..

4c070f98ca09255a54fb3fc9efbcf9d6e099ac96

Fri, Feb 21, 1:39 PM
vlorentz closed D2704: Add test for git directory entries order..

e10924140b409e77edc2d7501dbcfea4b46329b5

Fri, Feb 21, 1:39 PM
vlorentz closed D2701: Add support for skipping large contents in from_disk..

60c3aa16cf8778c7413606e2a532cfc47966d63c

Fri, Feb 21, 1:39 PM
vlorentz committed rDMOD4c070f98ca09: Sort from_disk.Directory entries. (authored by vlorentz).
Sort from_disk.Directory entries.
Fri, Feb 21, 1:39 PM
vlorentz committed rDMOD60c3aa16cf87: Add support for skipping large contents in from_disk. (authored by vlorentz).
Add support for skipping large contents in from_disk.
Fri, Feb 21, 1:39 PM
vlorentz committed rDMODe10924140b40: Add test for git directory entries order. (authored by vlorentz).
Add test for git directory entries order.
Fri, Feb 21, 1:39 PM
vlorentz accepted D2669: Add ?limit=N method variants to return first N results.

Looks good to me, thanks!

Fri, Feb 21, 12:23 PM
vlorentz updated the summary of D2702: Sort from_disk.Directory entries..
Fri, Feb 21, 12:03 PM
vlorentz updated the diff for D2702: Sort from_disk.Directory entries..

use git order

Fri, Feb 21, 12:03 PM
vlorentz created D2704: Add test for git directory entries order..
Fri, Feb 21, 12:03 PM

Thu, Feb 20

vlorentz added a comment to D2703: Add to_model() method to from_disk.{Content,Directory}, to convert to canonical model objects..
In D2703#64548, @olasd wrote:

We already have lots of issues with loaders having an "optimistic" usage of memory, so I'd be tempted to introduce a DiskBackedContent (DiskContent?) model, inheriting from Content, with a path attribute as well as a lazy data attribute that will read data from disk the first time it's accessed.

What's the difference?

The difference between what and what?

Thu, Feb 20, 8:09 PM
vlorentz planned changes to D2702: Sort from_disk.Directory entries..
Thu, Feb 20, 5:46 PM
vlorentz updated the diff for D2701: Add support for skipping large contents in from_disk..

add doc for max_content_length.

Thu, Feb 20, 5:33 PM
vlorentz added inline comments to D2701: Add support for skipping large contents in from_disk..
Thu, Feb 20, 5:29 PM
vlorentz added a comment to D2703: Add to_model() method to from_disk.{Content,Directory}, to convert to canonical model objects..
In D2703#64521, @olasd wrote:

That'd be a lot more work downstream, but wouldn't it make sense to have get_data return model objects directly instead of dicts?

Thu, Feb 20, 5:27 PM
vlorentz added a comment to D2703: Add to_model() method to from_disk.{Content,Directory}, to convert to canonical model objects..

By default, from_disk will not pull the full data from disk into memory, so by doing this there's a good chance you'll end up with a Content object that has an empty data attribute.

Thu, Feb 20, 5:24 PM
vlorentz created D2703: Add to_model() method to from_disk.{Content,Directory}, to convert to canonical model objects..
Thu, Feb 20, 4:51 PM
vlorentz created D2702: Sort from_disk.Directory entries..
Thu, Feb 20, 4:47 PM
vlorentz updated the diff for D2701: Add support for skipping large contents in from_disk..

reword comment

Thu, Feb 20, 4:44 PM
vlorentz created D2701: Add support for skipping large contents in from_disk..
Thu, Feb 20, 4:42 PM
vlorentz accepted D2700: retry: Add support for tenacity < 5.0.

That explain the inconsistent behavior I noticed in tenacity... thanks!

Thu, Feb 20, 1:37 PM
vlorentz requested changes to D2681: add anotation type in some lister file.

I see you did not annotate some of the functions. Do you need help with those?

Thu, Feb 20, 1:32 PM

Wed, Feb 19

vlorentz claimed T1258: Synthesize release objects for all upstream things that match the concept of a release.
Wed, Feb 19, 5:53 PM · Archive content
vlorentz created D2697: Move revision loading logic to its own function..
Wed, Feb 19, 5:49 PM
vlorentz committed rDSEAe148fbd81191: Fix compatibility with msgpack >= 1.0 (authored by vlorentz).
Fix compatibility with msgpack >= 1.0
Wed, Feb 19, 4:59 PM
vlorentz closed D2694: Fix compatibility with msgpack >= 1.0.
Wed, Feb 19, 4:59 PM
vlorentz committed rDLDSVNd45b80095750: Use swh-storage validation proxy earlier in the pipeline. (authored by vlorentz).
Use swh-storage validation proxy earlier in the pipeline.
Wed, Feb 19, 4:18 PM
vlorentz committed rDLDHGa9028c1115c3: Use swh-storage validation proxy earlier in the pipeline. (authored by vlorentz).
Use swh-storage validation proxy earlier in the pipeline.
Wed, Feb 19, 4:17 PM
vlorentz committed rDLDG7ce4fe662972: Use swh-storage validation proxy earlier in the pipeline. (authored by vlorentz).
Use swh-storage validation proxy earlier in the pipeline.
Wed, Feb 19, 4:17 PM
vlorentz committed rDLDBASE0324c957fdbb: Use swh-storage validation proxy earlier in the pipeline. (authored by vlorentz).
Use swh-storage validation proxy earlier in the pipeline.
Wed, Feb 19, 4:17 PM
vlorentz closed D2692: Use swh-storage validation proxy earlier in the pipeline..
Wed, Feb 19, 4:17 PM
vlorentz closed D2695: Add support for non-str/bytes keys for msgpack >= 1.0..

5f4452e0d71cf0f1491df115915b9854890a5cb1

Wed, Feb 19, 3:58 PM
vlorentz accepted D2696: Use fast hypothesis profile if none has been explicitely set.
Wed, Feb 19, 3:44 PM
vlorentz updated the summary of D2695: Add support for non-str/bytes keys for msgpack >= 1.0..
Wed, Feb 19, 2:55 PM
vlorentz updated the diff for D2695: Add support for non-str/bytes keys for msgpack >= 1.0..

update commit message to mention swh-scheduler

Wed, Feb 19, 2:55 PM
vlorentz created D2695: Add support for non-str/bytes keys for msgpack >= 1.0..
Wed, Feb 19, 2:50 PM
vlorentz created D2694: Fix compatibility with msgpack >= 1.0.
Wed, Feb 19, 2:36 PM
vlorentz committed rDCOREabbf366bb93a: Fix tests for msgpack >= 1.0 (authored by vlorentz).
Fix tests for msgpack >= 1.0
Wed, Feb 19, 2:33 PM
vlorentz closed D2693: Fix tests for msgpack >= 1.0.
Wed, Feb 19, 2:33 PM
vlorentz updated the diff for D2693: Fix tests for msgpack >= 1.0.

rebase

Wed, Feb 19, 2:33 PM
vlorentz created D2693: Fix tests for msgpack >= 1.0.
Wed, Feb 19, 2:28 PM
vlorentz committed rDCIDX4084077ac71d: Add a new IndexerStorageArgumentException class, for exceptions caused by the… (authored by vlorentz).
Add a new IndexerStorageArgumentException class, for exceptions caused by the…
Wed, Feb 19, 2:15 PM
vlorentz closed D2690: Add a new IndexerStorageArgumentException class, for exceptions caused by the client..
Wed, Feb 19, 2:15 PM
vlorentz added a comment to D2683: Make create_task_type idempotent.

But then, errors would pass silently...

Wed, Feb 19, 2:14 PM
vlorentz updated the test plan for D2692: Use swh-storage validation proxy earlier in the pipeline..
Wed, Feb 19, 1:41 PM
vlorentz created D2692: Use swh-storage validation proxy earlier in the pipeline..
Wed, Feb 19, 1:41 PM
vlorentz added inline comments to D2681: add anotation type in some lister file.
Wed, Feb 19, 12:21 PM

Tue, Feb 18

vlorentz updated the task description for T1805: Public API v2.
Tue, Feb 18, 4:54 PM · meta-task, Web app
vlorentz added a project to T2215: Streaming support everywhere: meta-task.
Tue, Feb 18, 4:52 PM · meta-task, Web app, Object storage, Storage manager, Restricted Project
vlorentz updated the task description for T2290: Implement origin_metadata endpoints in swh/storage/cassandra/.
Tue, Feb 18, 4:50 PM · Easy hack, Storage manager
vlorentz renamed T2291: Implement metadata_provider endpoints in swh/storage/cassandra/ from T2290: Implement metadata_provider endpoints in swh/storage/cassandra/ to Implement metadata_provider endpoints in swh/storage/cassandra/.
Tue, Feb 18, 4:50 PM · Easy hack, Storage manager
vlorentz triaged T2291: Implement metadata_provider endpoints in swh/storage/cassandra/ as Normal priority.
Tue, Feb 18, 4:49 PM · Easy hack, Storage manager
vlorentz added projects to T2290: Implement origin_metadata endpoints in swh/storage/cassandra/: Storage manager, Easy hack.
Tue, Feb 18, 4:48 PM · Easy hack, Storage manager
vlorentz triaged T2290: Implement origin_metadata endpoints in swh/storage/cassandra/ as Normal priority.
Tue, Feb 18, 4:48 PM · Easy hack, Storage manager
vlorentz accepted D2691: api: Fix error when no extra_encoders is given to negotiate.

Shouldn't the new test be in a new tests module?

Tue, Feb 18, 4:38 PM
vlorentz added inline comments to D2683: Make create_task_type idempotent.
Tue, Feb 18, 4:30 PM
vlorentz accepted D2689: common/service: Handle trailing url slashes in lookup_origin.
Tue, Feb 18, 4:25 PM
vlorentz accepted D2660: Adding 'Add Origin info' checkbox which was missing.
Tue, Feb 18, 4:23 PM
vlorentz updated the diff for D2690: Add a new IndexerStorageArgumentException class, for exceptions caused by the client..

update doctest

Tue, Feb 18, 3:48 PM
vlorentz created D2690: Add a new IndexerStorageArgumentException class, for exceptions caused by the client..
Tue, Feb 18, 3:38 PM
vlorentz requested changes to D2685: test_storage: Fix some RPC tests after recent changes in swh-core.
Tue, Feb 18, 3:10 PM
vlorentz added a comment to D2685: test_storage: Fix some RPC tests after recent changes in swh-core.
In D2685#64238, @olasd wrote:

I guess we should have the RPC client/server pair re-raise ValueErrors? @vlorentz?

Tue, Feb 18, 3:10 PM
vlorentz closed D2676: Add support for (de)serializing swh-model in RPC calls..
Tue, Feb 18, 3:04 PM
vlorentz committed rDSTO7cf086496b91: Add support for (de)serializing swh-model in RPC calls. (authored by vlorentz).
Add support for (de)serializing swh-model in RPC calls.
Tue, Feb 18, 3:04 PM
vlorentz updated the diff for D2676: Add support for (de)serializing swh-model in RPC calls..

rebase

Tue, Feb 18, 2:22 PM
vlorentz committed rDSTO80befa57ff9d: Make storage proxies use swh-model objects instead of dicts. (authored by vlorentz).
Make storage proxies use swh-model objects instead of dicts.
Tue, Feb 18, 2:18 PM
vlorentz closed D2664: Make storage proxies use swh-model objects instead of dicts..
Tue, Feb 18, 2:18 PM
vlorentz accepted D2674: Force recooking of an object when previous vault task failed.
Tue, Feb 18, 2:12 PM
vlorentz closed D2688: Handle ObjNotFoundError and Error as client errors instead of server errors..
Tue, Feb 18, 2:10 PM
vlorentz committed rDOBJSb23bf3fa4c11: Handle ObjNotFoundError and Error as client errors instead of server errors. (authored by vlorentz).
Handle ObjNotFoundError and Error as client errors instead of server errors.
Tue, Feb 18, 2:10 PM
vlorentz committed rDSTO29b09486ecf0: Fix FilteringProxy to not drop skipped-contents with a missing sha1_git. (authored by vlorentz).
Fix FilteringProxy to not drop skipped-contents with a missing sha1_git.
Tue, Feb 18, 2:09 PM
vlorentz closed D2663: Fix FilteringProxy to not drop skipped-contents with a missing sha1_git..
Tue, Feb 18, 2:09 PM
vlorentz requested changes to D2689: common/service: Handle trailing url slashes in lookup_origin.
Tue, Feb 18, 2:09 PM
vlorentz updated the diff for D2688: Handle ObjNotFoundError and Error as client errors instead of server errors..

update copyrights

Tue, Feb 18, 2:03 PM
vlorentz committed rDCORE7f19c0dcca61: Remove exception pickling from the async server, as in the sync server. (authored by vlorentz).
Remove exception pickling from the async server, as in the sync server.
Tue, Feb 18, 1:54 PM
vlorentz closed D2687: Remove exception pickling from the async server, as in the sync server..
Tue, Feb 18, 1:54 PM
vlorentz updated the diff for D2687: Remove exception pickling from the async server, as in the sync server..

update copyright

Tue, Feb 18, 1:53 PM
vlorentz updated the diff for D2664: Make storage proxies use swh-model objects instead of dicts..

rebase

Tue, Feb 18, 1:45 PM
vlorentz updated the diff for D2663: Fix FilteringProxy to not drop skipped-contents with a missing sha1_git..

rebase

Tue, Feb 18, 1:45 PM
vlorentz closed D2662: Fix inconsistent behavior of skipped_content_missing across backends..
Tue, Feb 18, 1:44 PM
vlorentz committed rDSTO51b20164f6eb: Fix inconsistent behavior of skipped_content_missing across backends. (authored by vlorentz).
Fix inconsistent behavior of skipped_content_missing across backends.
Tue, Feb 18, 1:44 PM
vlorentz added a comment to D2684: objstorage_testsing: Fix some RPC tests after recent changes in swh-core.

Abandoning this and let @vlorentz properly fixing the issue

Tue, Feb 18, 1:39 PM
vlorentz created D2688: Handle ObjNotFoundError and Error as client errors instead of server errors..
Tue, Feb 18, 1:39 PM
vlorentz created D2687: Remove exception pickling from the async server, as in the sync server..
Tue, Feb 18, 1:34 PM
vlorentz committed rDMOD2c1e02b897f0: Add method BaseModel.hashes(). (authored by vlorentz).
Add method BaseModel.hashes().
Tue, Feb 18, 11:36 AM
vlorentz closed D2677: Add method BaseModel.hashes()..
Tue, Feb 18, 11:36 AM
vlorentz committed rDCORE9667700ab536: Use iso8601.parse_date instead of dateutil.parser.parse. (authored by vlorentz).
Use iso8601.parse_date instead of dateutil.parser.parse.
Tue, Feb 18, 11:34 AM
vlorentz closed D2678: Use iso8601.parse_date instead of dateutil.parser.parse..
Tue, Feb 18, 11:34 AM
vlorentz updated the diff for D2678: Use iso8601.parse_date instead of dateutil.parser.parse..

change base commit

Tue, Feb 18, 11:32 AM
vlorentz committed rDCORE9cdc9168b264: Add extra_type_encoders and extra_type_decoders attributes to RPC clients and… (authored by vlorentz).
Add extra_type_encoders and extra_type_decoders attributes to RPC clients and…
Tue, Feb 18, 11:32 AM
vlorentz committed rDCORE9b3e3aa64673: Add support for extra {de,en}coders. (authored by vlorentz).
Add support for extra {de,en}coders.
Tue, Feb 18, 11:31 AM
vlorentz closed D2675: Add extra_type_encoders and extra_type_decoders attributes to RPC clients and servers..
Tue, Feb 18, 11:31 AM
vlorentz closed D2672: Add support for extra {de,en}coders..
Tue, Feb 18, 11:31 AM