Page MenuHomeSoftware Heritage
Differential D2723

Make the RPC client and objstorage helper fetch Content.data.
ClosedPublic
Actions

Authored by vlorentz on Feb 27 2020, 4:58 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTOd096542f8fae: Make the RPC client and objstorage helper fetch Content.data.
Summary

This is needed when a lazy subclass of Content is used, eg.
from swh.model.from_disk.

Depends on D2722.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 27 2020, 4:58 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 27 2020, 4:58 PM
ardumont accepted this revision.Feb 27 2020, 5:56 PM
This revision is now accepted and ready to land.Feb 27 2020, 5:56 PM
swh-public-ci added a comment.Feb 28 2020, 10:27 AM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1009/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1009/console

Harbormaster failed remote builds in B10785: Diff 9717!Feb 28 2020, 10:27 AM
vlorentz mentioned this in D2727: Allow subclasses of RPCClient to override methods..Feb 28 2020, 11:52 AM
swh-public-ci added a comment.Feb 28 2020, 12:09 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1013/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1013/console

swh-public-ci added a comment.Feb 28 2020, 2:36 PM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1014/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1014/console

swh-public-ci added a comment.Feb 28 2020, 2:43 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1015/ for more details.

Harbormaster completed remote builds in B10785: Diff 9717.Feb 28 2020, 2:43 PM
Closed by commit rDSTOd096542f8fae: Make the RPC client and objstorage helper fetch Content.data. (authored by vlorentz). · Explain WhyFeb 28 2020, 2:43 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSTOd096542f8fae: Make the RPC client and objstorage helper fetch Content.data..

Revision Contents
Changeset List

PathSize
swh/
storage/
api/
8 lines
9 lines
tests/
4 lines
49 lines

Diff 9740

View Options

swh/storage/api/client.py

Loading...
View Options

swh/storage/objstorage.py

Loading...
View Options

swh/storage/tests/test_api_client_dicts.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal