Page MenuHomeSoftware Heritage
Differential D2745

Move Person parsing to swh-model.
ClosedPublic
Actions

Authored by vlorentz on Mar 2 2020, 4:00 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDLDSVN1d4c77a52fc2: Move Person parsing to swh-model.

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mar 2 2020, 4:00 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 2 2020, 4:00 PM
swh-public-ci added a comment.Mar 2 2020, 4:00 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/71/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/71/console

Harbormaster failed remote builds in B10839: Diff 9777!Mar 2 2020, 4:00 PM
olasd accepted this revision.Mar 3 2020, 1:25 PM
olasd added a subscriber: olasd.

Same comments as swh.loader.git: accept pending potential api change in the base diff.

and: Do we really need to keep this indirection (we even have two levels of it here)?

This revision is now accepted and ready to land.Mar 3 2020, 1:25 PM
vlorentz added a comment.Mar 3 2020, 1:37 PM

We probably want to keep svn_author_to_swh_person, as it deals with the None case. As for convert_commit_author, I just kept it as is, but probably not.

vlorentz updated this revision to Diff 9853.Mar 5 2020, 12:10 PM

update tests

swh-public-ci added a comment.Mar 5 2020, 12:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/72/ for more details.

Harbormaster completed remote builds in B10920: Diff 9853.Mar 5 2020, 12:11 PM
Closed by commit rDLDSVN1d4c77a52fc2: Move Person parsing to swh-model. (authored by vlorentz). · Explain WhyMar 6 2020, 3:52 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDLDSVN1d4c77a52fc2: Move Person parsing to swh-model..

Revision Contents
Changeset List

PathSize
2 lines
swh/
loader/
svn/
26 lines
10 lines
tests/
6 lines

Diff 9907

View Options

requirements-swh.txt

Loading...
View Options

swh/loader/svn/converters.py

Loading...
View Options

swh/loader/svn/svn.py

Loading...
View Options

swh/loader/svn/tests/test_converters.py

Loading...
About · Developer information · Legal