test_storage: Fix some RPC tests after recent changes in swh-core
AbandonedPublic
Actions

Authored by anlambert on Feb 17 2020, 5:50 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Summary

Remote exception handling has changed since rDCORE08289ce5c33e507ec3ce80cade86f688b4107f3f

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

fix-rpc-tests

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10640
Build 15942: tox-on-jenkins	Jenkins
Build 15941: arc lint + arc unit

Event Timeline

anlambert created this revision.Feb 17 2020, 5:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 17 2020, 5:50 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/689/ for more details.

Harbormaster completed remote builds in B10640: Diff 9581.Feb 17 2020, 5:56 PM

I guess we should have the RPC client/server pair re-raise ValueErrors? @vlorentz?

In D2685#64238, @olasd wrote:

I guess we should have the RPC client/server pair re-raise ValueErrors? @vlorentz?

RemoteException means an unexpected server error (http code 500).

As those errors are client errors, I think we should use another class. reraising ValueError is a bad option, because server errors may raise those too. Instead, we should add a new exception type, and raise that one.

vlorentz requested changes to this revision.Feb 18 2020, 3:10 PM

This revision now requires changes to proceed.Feb 18 2020, 3:10 PM

vlorentz mentioned this in D2690: Add a new IndexerStorageArgumentException class, for exceptions caused by the client..Feb 18 2020, 3:38 PM

Replaced by D2690

anlambert abandoned this revision.Feb 28 2020, 2:18 PM

Revision Contents
Changeset List

Path

Size

swh/

indexer/

tests/

storage/

test_storage.py

25 lines

Diff 9581

View Options

swh/indexer/tests/storage/test_storage.py

test_storage: Fix some RPC tests after recent changes in swh-coreAbandonedPublicActions