Reintroduce support for decoding legacy msgpack encoding
ClosedPublic
Actions

Authored by olasd on Feb 25 2020, 12:56 PM.

Details

Reviewers

vlorentz
ardumont

Commits

rDCORE6d6a861dc6be: Reintroduce support for decoding legacy msgpack encoding

Summary

The full contents of the journal are encoded with this schema, so we should keep
supporting it

Test Plan

new unit test added

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Feb 25 2020, 12:56 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/423/ for more details.

Harbormaster completed remote builds in B10749: Diff 9684.Feb 25 2020, 12:58 PM

Perfect, thanks!

This revision is now accepted and ready to land.Feb 25 2020, 12:58 PM

although you should change the commit message: "The full contents of the journal" -> "The existing contents of the journal"

ardumont accepted this revision.Feb 25 2020, 1:00 PM

Clarify commit message

This revision was landed with ongoing or failed builds.Feb 25 2020, 1:04 PM

Closed by commit rDCORE6d6a861dc6be: Reintroduce support for decoding legacy msgpack encoding (authored by olasd). · Explain Why

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDCORE6d6a861dc6be: Reintroduce support for decoding legacy msgpack encoding.

Harbormaster failed remote builds in B10750: Diff 9685!Feb 25 2020, 1:05 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/424/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/424/console

Revision Contents
Changeset List

Path

Size

swh/

core/

api/

serializers.py

13 lines

tests/

test_serializers.py

35 lines

Diff 9686

View Options

swh/core/api/serializers.py