Differential D2712

Take the value of MerkleNode.data into account to compute equality.
ClosedPublic
Actions

Authored by vlorentz on Feb 24 2020, 4:07 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDMODc0ce38ed4948: Take the value of MerkleNode.data into account to compute equality.

Summary

It just makes more sense that way.

eg. before this change, all leafs would be equal to each other.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 24 2020, 4:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 24 2020, 4:07 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/189/ for more details.

Harbormaster completed remote builds in B10742: Diff 9675.Feb 24 2020, 4:08 PM

vlorentz added a child revision: D2713: Add method MerkleNode.iter_tree, to visit all nodes in the subtree of a node..Feb 24 2020, 4:10 PM

It does make more sense that way.

This revision is now accepted and ready to land.Feb 24 2020, 4:21 PM

Closed by commit rDMODc0ce38ed4948: Take the value of MerkleNode.data into account to compute equality. (authored by vlorentz). · Explain WhyFeb 27 2020, 3:14 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDMODc0ce38ed4948: Take the value of MerkleNode.data into account to compute equality..

Revision Contents
Changeset List

Path

Size

swh/

model/

merkle.py

7 lines

tests/

test_merkle.py

22 lines

Diff 9710

View Options

swh/model/merkle.py