Page MenuHomeSoftware Heritage
Differential D2690

Add a new IndexerStorageArgumentException class, for exceptions caused by the client.
ClosedPublic
Actions

Authored by vlorentz on Feb 18 2020, 3:38 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDCIDX4084077ac71d: Add a new IndexerStorageArgumentException class, for exceptions caused by the…
Summary

And re-raise them through the RPC layer.

This is now required by swh-core, as exceptions are no longer pickled.

Replaces D2685.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 18 2020, 3:38 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 18 2020, 3:38 PM
swh-public-ci added a comment.Feb 18 2020, 3:45 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/690/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/690/console

Harbormaster failed remote builds in B10676: Diff 9615!Feb 18 2020, 3:45 PM
vlorentz updated this revision to Diff 9616.Feb 18 2020, 3:48 PM

update doctest

swh-public-ci added a comment.Feb 18 2020, 3:54 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/691/ for more details.

Harbormaster completed remote builds in B10677: Diff 9616.Feb 18 2020, 3:54 PM
olasd accepted this revision.Feb 19 2020, 2:09 PM
This revision is now accepted and ready to land.Feb 19 2020, 2:09 PM
Closed by commit rDCIDX4084077ac71d: Add a new IndexerStorageArgumentException class, for exceptions caused by the… (authored by vlorentz). · Explain WhyFeb 19 2020, 2:15 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCIDX4084077ac71d: Add a new IndexerStorageArgumentException class, for exceptions caused by the….
vlorentz mentioned this in D2685: test_storage: Fix some RPC tests after recent changes in swh-core.Feb 28 2020, 2:18 PM

Revision Contents
Changeset List

PathSize
swh/
indexer/
storage/
39 lines
api/
10 lines
6 lines
19 lines
36 lines
tests/
storage/
17 lines

Diff 9625

View Options

swh/indexer/storage/__init__.py

Loading...
View Options

swh/indexer/storage/api/client.py

Loading...
View Options

swh/indexer/storage/api/server.py

Loading...
View Options

swh/indexer/storage/exc.py

Loading...
View Options

swh/indexer/storage/in_memory.py

Loading...
View Options

swh/indexer/tests/storage/test_storage.py

Loading...
About · Developer information · Legal