Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDJNL6ca43d5c59e6: JournalClient: add a stop_at_eof boolean to read the log only once
Diff Detail
- Repository
- rDJNL Journal infrastructure
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| swh/journal/client.py | ||
|---|---|---|
| 179–182 | Here I could have used an exception instead of returning a tuple. Any thoughts? | |
| swh/journal/tests/test_client.py | ||
| 54 | Most of this is copy pasted from the function above, but I'm not sure if it's worth to factor, and *how* we should factor it. I can write a fixture that yields a kafka_prefix maybe? | |
| swh/journal/client.py | ||
|---|---|---|
| 213–214 | This code is unsound. Your client may reach EOF on some partitions, then get rebalanced on other partitions, reach EOF on some other partitions; but it will count the older partitions on the left side. | |
Build was aborted
Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/333/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/333/console
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/334/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/334/console