Page MenuHomeSoftware Heritage
Differential D2738

Add a method to generate a Content from binary data
ClosedPublic
Actions

Authored by olasd on Mar 2 2020, 2:07 PM.

Details

Reviewers
ardumont
vlorentz
Group Reviewers
Reviewers
Commits
rDMODded150d6c32e: Add a method to generate Content/SkippedContent from binary data
Summary

This lets us generate Content objects directly from a bytestring, with the
proper set of hashes auto-generated from the contents.

Test Plan

added tox tests

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Mar 2 2020, 2:07 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 2 2020, 2:07 PM
swh-public-ci added a comment.Mar 2 2020, 2:08 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/197/ for more details.

Harbormaster completed remote builds in B10828: Diff 9766.Mar 2 2020, 2:08 PM
ardumont accepted this revision.Mar 2 2020, 2:10 PM
This revision is now accepted and ready to land.Mar 2 2020, 2:10 PM
olasd added a child revision: D2739: Draw contents from a byte string instead of generating arbitrary hashes.Mar 2 2020, 2:11 PM
vlorentz requested changes to this revision.Mar 2 2020, 3:23 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/model/model.py
411

reason should default to None, and the function error if it's not set.

This revision now requires changes to proceed.Mar 2 2020, 3:23 PM
olasd updated this revision to Diff 9775.Mar 2 2020, 3:59 PM

Shuffle methods around to improve arguments handling

olasd marked an inline comment as done.Mar 2 2020, 4:00 PM
swh-public-ci added a comment.Mar 2 2020, 4:00 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/201/ for more details.

Harbormaster completed remote builds in B10837: Diff 9775.Mar 2 2020, 4:00 PM
vlorentz added inline comments.Mar 2 2020, 4:02 PM
swh/model/model.py
392–399

Maybe prepend an underscore? There's not reason for it to be used by other modules.

olasd updated this revision to Diff 9778.Mar 2 2020, 4:19 PM

Underscore internal method

olasd marked an inline comment as done.Mar 2 2020, 4:19 PM
swh-public-ci added a comment.Mar 2 2020, 4:20 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/203/ for more details.

Harbormaster completed remote builds in B10840: Diff 9778.Mar 2 2020, 4:20 PM
olasd updated this revision to Diff 9780.Mar 2 2020, 4:22 PM

Moar docstrings

swh-public-ci added a comment.Mar 2 2020, 4:23 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/205/ for more details.

Harbormaster completed remote builds in B10842: Diff 9780.Mar 2 2020, 4:23 PM
vlorentz accepted this revision.Mar 2 2020, 4:25 PM
This revision is now accepted and ready to land.Mar 2 2020, 4:25 PM
Closed by commit rDMODded150d6c32e: Add a method to generate Content/SkippedContent from binary data (authored by olasd). · Explain WhyMar 2 2020, 4:27 PM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDMODded150d6c32e: Add a method to generate Content/SkippedContent from binary data.

Revision Contents
Changeset List

PathSize
swh/
model/
38 lines
tests/
35 lines

Diff 9782

View Options

swh/model/model.py

Loading...
View Options

swh/model/tests/test_model.py

Loading...
About · Developer information · Legal