replay: drop the hand-rolled retry contextmanager
ClosedPublic
Actions

Authored by olasd on Mar 2 2020, 7:19 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDJNL1e277b418958: replay: drop the hand-rolled retry contextmanager

Summary

It makes the consumer crash with generator didn't stop after throw()
exceptions. We'll reintroduce retry behavior at a later stage.

Test Plan

tox output is unchanged

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Mar 2 2020, 7:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 2 2020, 7:19 PM

wait, so that contextmanager didn't work at all?

This revision is now accepted and ready to land.Mar 2 2020, 7:20 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/337/ for more details.

Harbormaster completed remote builds in B10853: Diff 9796.Mar 2 2020, 7:22 PM

In D2750#65569, @vlorentz wrote:

wait, so that contextmanager didn't work at all?

No, it did not. contextmanager expects its function to yield only once.

Closed by commit rDJNL1e277b418958: replay: drop the hand-rolled retry contextmanager (authored by olasd). · Explain WhyMar 3 2020, 10:13 AM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDJNL1e277b418958: replay: drop the hand-rolled retry contextmanager.

Revision Contents
Changeset List

Path

Size

swh/

journal/

replay.py

26 lines

Diff 9801

View Options

replay: drop the hand-rolled retry contextmanagerClosedPublicActions