Page MenuHomeSoftware Heritage
Differential D2743

Move Person parsing to swh-model.
ClosedPublic
Actions

Authored by vlorentz on Mar 2 2020, 3:58 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDLDBASEf8ffdec2891b: Move Person parsing to swh-model.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mar 2 2020, 3:58 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 2 2020, 3:58 PM
swh-public-ci added a comment.Mar 2 2020, 3:59 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/339/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/339/console

Harbormaster failed remote builds in B10835: Diff 9773!Mar 2 2020, 3:59 PM
olasd added a subscriber: olasd.Mar 3 2020, 1:21 PM

Changes look sensible.

I'm surprised that this change doesn't incur a change of the id some of the tested revisions (e.g. in the npm case).

This is something that we should probably cover better.

vlorentz added a comment.Mar 3 2020, 1:35 PM
In D2743#65674, @olasd wrote:

I'm surprised that this change doesn't incur a change of the id some of the tested revisions (e.g. in the npm case).

This is something that we should probably cover better.

The id only changes if there is an URL after the email; which isn't tested afaik

anlambert mentioned this in D2742: Add classmethod Person.from_address, to parse from 'name <email>' strings..Mar 3 2020, 1:36 PM
olasd requested changes to this revision.Mar 4 2020, 5:06 PM

This now needs an update to use from_fullname.

This revision now requires changes to proceed.Mar 4 2020, 5:06 PM
vlorentz updated this revision to Diff 9858.Mar 5 2020, 1:31 PM

from_fullname

swh-public-ci added a comment.Mar 5 2020, 1:32 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/340/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/340/console

Harbormaster failed remote builds in B10925: Diff 9858!Mar 5 2020, 1:32 PM
vlorentz updated this revision to Diff 9861.Mar 5 2020, 1:43 PM

str -> bytes

swh-public-ci added a comment.Mar 5 2020, 1:45 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/341/ for more details.

Harbormaster completed remote builds in B10929: Diff 9861.Mar 5 2020, 1:45 PM
olasd accepted this revision.Mar 6 2020, 2:53 PM
This revision is now accepted and ready to land.Mar 6 2020, 2:53 PM
Closed by commit rDLDBASEf8ffdec2891b: Move Person parsing to swh-model. (authored by vlorentz). · Explain WhyMar 6 2020, 3:52 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDLDBASEf8ffdec2891b: Move Person parsing to swh-model..

Revision Contents
Changeset List

PathSize
2 lines
swh/
loader/
package/
cran/
6 lines
npm/
7 lines
tests/
4 lines
tests/
144 lines
81 lines

Diff 9906

View Options

requirements-swh.txt

Loading...
View Options

swh/loader/package/cran/loader.py

Loading...
View Options

swh/loader/package/npm/loader.py

Loading...
View Options

swh/loader/package/npm/tests/test_npm.py

Loading...
View Options

swh/loader/package/tests/test_utils.py

Loading...
View Options

swh/loader/package/utils.py

Loading...
About · Developer information · Legal