Page MenuHomeSoftware Heritage
Differential D2720

Add from_datetime and from_iso8601 constructors for TimestampWithTimezone.
ClosedPublic
Actions

Authored by vlorentz on Feb 27 2020, 2:33 PM.

Details

Reviewers
olasd
ardumont
Group Reviewers
Reviewers
Commits
rDMOD750d147131ba: Add from_datetime and from_iso8601 constructors for TimestampWithTimezone.
Summary

Depends on D2713.

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 27 2020, 2:33 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 27 2020, 2:33 PM
vlorentz mentioned this in D2714: Use swh-model objects in package loader..Feb 27 2020, 2:34 PM
swh-public-ci added a comment.Feb 27 2020, 2:34 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/192/ for more details.

Harbormaster completed remote builds in B10770: Diff 9704.Feb 27 2020, 2:34 PM
olasd requested changes to this revision.Feb 27 2020, 2:34 PM
olasd added a subscriber: olasd.

No tests?

This revision now requires changes to proceed.Feb 27 2020, 2:34 PM
vlorentz updated this revision to Diff 9705.Feb 27 2020, 2:54 PM

add test + negative utc

swh-public-ci added a comment.Feb 27 2020, 2:55 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/193/ for more details.

Harbormaster completed remote builds in B10771: Diff 9705.Feb 27 2020, 2:55 PM
ardumont accepted this revision.Feb 27 2020, 2:57 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/model/model.py
144

Buil`d`s

olasd accepted this revision.Feb 27 2020, 3:10 PM
This revision is now accepted and ready to land.Feb 27 2020, 3:10 PM
vlorentz updated this revision to Diff 9707.Feb 27 2020, 3:10 PM

comments

swh-public-ci added a comment.Feb 27 2020, 3:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/194/ for more details.

Harbormaster completed remote builds in B10773: Diff 9707.Feb 27 2020, 3:11 PM
vlorentz updated this revision to Diff 9708.Feb 27 2020, 3:12 PM

fix base

vlorentz added a child revision: D2721: Make attributes name and email of Person optional..Feb 27 2020, 3:12 PM
swh-public-ci added a comment.Feb 27 2020, 3:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/195/ for more details.

Harbormaster completed remote builds in B10774: Diff 9708.Feb 27 2020, 3:13 PM
Closed by commit rDMOD750d147131ba: Add from_datetime and from_iso8601 constructors for TimestampWithTimezone. (authored by vlorentz). · Explain WhyFeb 27 2020, 3:14 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDMOD750d147131ba: Add from_datetime and from_iso8601 constructors for TimestampWithTimezone..

Revision Contents
Changeset List

PathSize
3 lines
1 line
swh/
model/
23 lines
tests/
55 lines

Diff 9712

View Options

mypy.ini

Loading...
View Options

requirements.txt

Loading...
View Options

swh/model/model.py

Loading...
View Options

swh/model/tests/test_model.py

Loading...
About · Developer information · Legal