+1, I was also thinking recently to implement such exception filtering but you were faster.

This has been implemented and is now used by swh-web in production, closing this.

Abandonned in favor of a better fix in D6230

Rebase and reword commit message

Looks good, thanks !

Rebase

Looks good but filesizeformat is already used in many views implementation (grep for it).

Update:

• rebase
• ensure click handler for code highlighting will not be created in iframe mode

In D6186#160753, @vlorentz wrote:

In D6186#160165, @vlorentz wrote:

I disabled lines highlighting for the iframe view through javascript, did you recompile the static assets before your tests ?

Yes (I have to, the python process crashes when I don't)

I just tried, and it seems I can't anymore... most of the time.

However, if I click on a line number right after it displayed the column, I can still one line and it will scroll to it.

Looks good to me.

Indeed some save requests are still marked as running while they clearly are not.

Looks good to me.

Update:

• rebase
• address @vlorentz comments
• fix a couple of spotted issues
• add sphinx documentation
• add modals displayable from the SWHIDs tab explaining how to integrate iframe views in external web page

Looks good to me.

Looks good to me.

Rebase

Rebase

Rebase

Rebase

Rebase

While testing, I noticed the dropdown items for the Browse extrinsic metadata button are the same as the Download one.
To add multiple dropdowns in a bootstrap btn-group, you need to wrap each dropdown in a new btn-group, see related post on stackoverflow.

When displaying content, the first line looks slightly smaller than the other ones; and when listing a revision/directory, text in the table header is not vertically centered. A few px in breadcrumbs-container's margin-bottom should fix it.

In D6186#160119, @vlorentz wrote:

Can you add a documentation page explaining how to use it?

Closing this as resolved, archive coverage widget has been updated accordingly and deployed.

@stsp , thanks for this !

Oh right, I missed those too during my yesterday reviews.

Would you have time during September to help on this task? (it is a roadmap task, btw)

I forgot to update the diff after local rebase, closed by rSPSITEe009324d13e8a6f3821bdc755a1c3ae9c044bf28.

I discussed this option with Kat from Data Current (in charge of the SWH stories interface) and she was wondering if the highlighted text will be centered.
Seems from your example that this will be the case.

Looks good to me.

In T3489#69769, @moranegg wrote:

@anlambert : Looks very good!
Can you show an example for a code fragment where you view a content with a few lines marked-up ?

I found a couple of issues while testing, see inline comments.