Page MenuHomeSoftware Heritage

browse/snapshot_context: Better handle missing revision edge case
ClosedPublic

Authored by anlambert on Thu, Sep 9, 3:57 PM.

Details

Summary

It exists some cases (nix and guix origins for instance) when a snapshot
branch targets a revision that is missing in the archive.

So ensure to remove Web UI components related to missing objects (revision
and directory) as they will lead to errors when following the links they
contain.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6230 (id=22541)

Rebasing onto 45583024a8...

Current branch diff-target is up to date.
Changes applied before test
commit cdebef28e78d78434e4af09f81b449757321277f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 9 15:01:52 2021 +0200

    browse/snapshot_context: Better handle missing revision edge case
    
    It exists some cases (nix and guix origins for instance) when a snapshot
    branch targets a revision that is missing in the archive.
    
    So ensure to remove Web UI components related to missing objects (revision
    and directory) as they will lead to errors when following the links they
    contain.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1104/ for more details.

This revision is now accepted and ready to land.Thu, Sep 9, 4:12 PM