Page MenuHomeSoftware Heritage

explicitly name the metadata search configuration property
ClosedPublic

Authored by vsellier on Tue, Sep 7, 2:41 PM.

Details

Summary

this property is only used for the metadata search.
Naming it search_config.backend is confusing as it lets suppose
it's the global search configuration

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6202 (id=22449)

Rebasing onto 8c8550a08a...

Current branch diff-target is up to date.
Changes applied before test
commit 777d9392103fde75ce61352830568d3682642d2b
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Sep 7 14:36:55 2021 +0200

    explicitly name the metadata search configuration property

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1084/ for more details.

Build is green

Patch application report for D6202 (id=22450)

Rebasing onto 8c8550a08a...

Current branch diff-target is up to date.
Changes applied before test
commit c302b9a5e40d311f667b4c915a88bc091c0e919d
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Sep 7 14:36:55 2021 +0200

    explicitly name the metadata search configuration property
    
    this property is only used for the metadata search.
    Naming it search_config.backend is confusing as it lets suppose
    it's the global search configuration

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1085/ for more details.

anlambert added a subscriber: anlambert.

Looks good to me.

This revision is now accepted and ready to land.Tue, Sep 7, 3:03 PM