Page MenuHomeSoftware Heritage

browse/snapshot_context: Ensure pull request branches can be browsed
ClosedPublic

Authored by anlambert on Tue, Sep 7, 4:22 PM.

Details

Summary

While pull request branches are hidden by default in Web UI, they should
remain browsable.

That commit fixes the error that was previously raised when attempting
to browse such a branch.

Related sentry issue

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build was aborted

Patch application report for D6207 (id=22470)

Rebasing onto b552b01dc7...

Current branch diff-target is up to date.
Changes applied before test
commit b5ed6955405629ad6469f0e33ce0afec89636f5d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 7 16:18:38 2021 +0200

    browse/snapshot_context: Ensure pull request branches can be browsed
    
    While pull request branches are hidden by default in Web UI, they should
    remain browsable.
    
    That commit fixes the error that was previously raised when attempting
    to browse such a branch.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1089/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1089/console

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Sep 7, 4:43 PM
Harbormaster failed remote builds in B23421: Diff 22470!

Build is green

Patch application report for D6207 (id=22470)

Rebasing onto b552b01dc7...

Current branch diff-target is up to date.
Changes applied before test
commit b5ed6955405629ad6469f0e33ce0afec89636f5d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 7 16:18:38 2021 +0200

    browse/snapshot_context: Ensure pull request branches can be browsed
    
    While pull request branches are hidden by default in Web UI, they should
    remain browsable.
    
    That commit fixes the error that was previously raised when attempting
    to browse such a branch.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1090/ for more details.

vlorentz added a subscriber: vlorentz.

I wonder if we should add a "Pull Request" tab on snapshot views. Seems like a rabbit hole to implement it correctly for all forges though...

swh/web/tests/browse/views/test_origin.py
1304–1309
This revision is now accepted and ready to land.Wed, Sep 8, 11:14 AM