Page MenuHomeSoftware Heritage

Switch the UI to use bare git archives, instead of gitfast.
ClosedPublic

Authored by vlorentz on Thu, Sep 2, 3:07 PM.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Sep 2, 3:11 PM
Harbormaster failed remote builds in B23315: Diff 22360!

fix file extension (it's .tar, not .tar.gz)

Build is green

Patch application report for D6171 (id=22360)

Rebasing onto 2a6ce0bc00...

Current branch diff-target is up to date.
Changes applied before test
commit e18d26018a9bcb950803bd5b05ad0dbe210baff0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 2 15:06:31 2021 +0200

    Switch the UI to use bare git archives, instead of gitfast.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1054/ for more details.

Build is green

Patch application report for D6171 (id=22363)

Rebasing onto 2a6ce0bc00...

Current branch diff-target is up to date.
Changes applied before test
commit a432e120ad70bc010ca08e529453ec2a02731972
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 2 15:06:31 2021 +0200

    Switch the UI to use bare git archives, instead of gitfast.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1055/ for more details.

Build is green

Patch application report for D6171 (id=22368)

Rebasing onto d0335365a4...

First, rewinding head to replay your work on top of it...
Applying: Switch the UI to use bare git archives, instead of gitfast.
Changes applied before test
commit 9ae4c8d0bc1a1310cf0ee2aff3e2eb7d839909cd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 2 15:06:31 2021 +0200

    Switch the UI to use bare git archives, instead of gitfast.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1057/ for more details.

anlambert added a subscriber: anlambert.

I found a couple of issues while testing, see inline comments.

assets/src/bundles/vault/vault-table-row.ejs
8

After you recent changes, this now must be:
<% if (cookingTask.bundle_type === 'flat') { %>

12

directory tarballs are still gzipped so that change must be reverted.

This revision now requires changes to proceed.Thu, Sep 2, 4:42 PM
assets/src/bundles/vault/vault-table-row.ejs
8

It doesn't. cookingTask.object_type still exists, and makes sense to decide what message to choose.

bundle_type === 'flat' does not imply it's a directory, we also have a flat cooker for revisions (even though it's not public)

undo change to dir tarball name

assets/src/bundles/vault/vault-table-row.ejs
8

Ok so the issue is elsewhere then as I got the git tooltip for directory during my tests ...

Build is green

Patch application report for D6171 (id=22372)

Rebasing onto d0335365a4...

First, rewinding head to replay your work on top of it...
Applying: Switch the UI to use bare git archives, instead of gitfast.
Changes applied before test
commit 9cb5177142124815246ec4d170b89d4f7edc76b6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 2 15:06:31 2021 +0200

    Switch the UI to use bare git archives, instead of gitfast.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1059/ for more details.

assets/src/bundles/vault/vault-table-row.ejs
8

will be fixed by D6175.

Good catch

This revision is now accepted and ready to land.Fri, Sep 3, 11:12 AM
This revision was landed with ongoing or failed builds.Fri, Sep 3, 1:43 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D6171 (id=22381)

Rebasing onto d0335365a4...

Current branch diff-target is up to date.
Changes applied before test
commit f324ac3a549c4cf4bd78210eeca57e639dfcf668
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 2 15:06:31 2021 +0200

    Switch the UI to use bare git archives, instead of gitfast.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1062/ for more details.