Page MenuHomeSoftware Heritage

Allow all hosts in tests
ClosedPublic

Authored by vlorentz on Tue, Sep 7, 12:14 PM.

Details

Summary

When working from home, I run swh-web remotely, so it's not on localhost.

Allow any host makes this simpler.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6198 (id=22444)

Rebasing onto 8c8550a08a...

First, rewinding head to replay your work on top of it...
Applying: Allow all hosts in tests
Changes applied before test
commit ae8065c19be5787a6c807cccbd88a487236b808c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 7 12:14:31 2021 +0200

    Allow all hosts in tests
    
    When working from home, I run swh-web remotely, so it's not on localhost.
    
    Allow any host makes this simpler.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1082/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1082/console

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Sep 7, 12:30 PM
Harbormaster failed remote builds in B23393: Diff 22444!

Build is green

Patch application report for D6198 (id=22444)

Rebasing onto 8c8550a08a...

First, rewinding head to replay your work on top of it...
Applying: Allow all hosts in tests
Changes applied before test
commit 0273a55a275f76243a75a1ec7387bf57434fa825
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 7 12:14:31 2021 +0200

    Allow all hosts in tests
    
    When working from home, I run swh-web remotely, so it's not on localhost.
    
    Allow any host makes this simpler.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1083/ for more details.

anlambert added a subscriber: anlambert.

Looks good to me.

swh/web/settings/tests.py
115–116

I guess you can remove these lines now.

This revision is now accepted and ready to land.Tue, Sep 7, 2:53 PM

Build is green

Patch application report for D6198 (id=22452)

Rebasing onto 8c8550a08a...

First, rewinding head to replay your work on top of it...
Applying: Allow all hosts in tests
Changes applied before test
commit ecd327f5037ad98d7c3ca716a512bfe7cd7d9132
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 7 12:14:31 2021 +0200

    Allow all hosts in tests
    
    When working from home, I run swh-web remotely, so it's not on localhost.
    
    Allow any host makes this simpler.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1086/ for more details.

This revision was landed with ongoing or failed builds.Tue, Sep 7, 3:10 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D6198 (id=22454)

Rebasing onto b552b01dc7...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-1087-D6198.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1087/ for more details.