Page MenuHomeSoftware Heritage

directory-display: Show human-readable file sizes (KB, MB, ...).
ClosedPublic

Authored by vlorentz on Wed, Sep 8, 5:21 PM.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6218 (id=22497)

Rebasing onto ec19895012...

Current branch diff-target is up to date.
Changes applied before test
commit 5d9075dc9eb09518ba9f74e4287c72821b0d8925
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Sep 8 17:21:16 2021 +0200

    directory-display: Show human-readable file sizes (KB, MB, ...).
    
    https://docs.djangoproject.com/en/3.2/ref/templates/builtins/#filesizeformat

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1097/ for more details.

This revision is now accepted and ready to land.Wed, Sep 8, 5:37 PM
anlambert added a subscriber: anlambert.

Looks good but filesizeformat is already used in many views implementation (grep for it).

I agree it is better to use it in template so we should remove their use in Python code before landing this.

This revision now requires changes to proceed.Wed, Sep 8, 5:41 PM

rebase + remove duplicate use of filesizeformat.

That's better indeed ;)

This revision is now accepted and ready to land.Thu, Sep 9, 11:25 AM

Build is green

Patch application report for D6218 (id=22515)

Rebasing onto 3d6abb9ae1...

Current branch diff-target is up to date.
Changes applied before test
commit 25654a2764b6428bcaf6228db059ab445da5ec05
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Sep 8 17:21:16 2021 +0200

    directory-display: Show human-readable file sizes (KB, MB, ...).
    
    https://docs.djangoproject.com/en/3.2/ref/templates/builtins/#filesizeformat

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1099/ for more details.