Page MenuHomeSoftware Heritage

stsp (Stefan Sperling)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 5 2021, 10:03 AM (29 w, 3 d)

Recent Activity

Thu, Jan 6

stsp closed D6823: validate input paths in the CVS loader.
Thu, Jan 6, 12:38 PM
stsp committed rDLDCVS238c9c0335af: validate input paths in the CVS loader (authored by stsp).
validate input paths in the CVS loader
Thu, Jan 6, 12:38 PM
stsp updated the diff for D6823: validate input paths in the CVS loader.

rebased patch

Thu, Jan 6, 12:36 PM
stsp updated the diff for D6823: validate input paths in the CVS loader.

new patch with some suggestions from ardumont applied

Thu, Jan 6, 12:26 PM

Dec 17 2021

stsp updated the diff for D6823: validate input paths in the CVS loader.

remove self.log.info() call that was used for debugging

Dec 17 2021, 12:12 PM
stsp updated the diff for D6823: validate input paths in the CVS loader.

new version which uses a mock class for the test

Dec 17 2021, 12:08 PM
stsp added inline comments to D6823: validate input paths in the CVS loader.
Dec 17 2021, 12:07 PM
stsp updated the diff for D6823: validate input paths in the CVS loader.

move path-safety check into a helper function

Dec 17 2021, 11:41 AM
stsp added inline comments to D6823: validate input paths in the CVS loader.
Dec 17 2021, 11:38 AM

Dec 16 2021

stsp added a comment to T3692: Stabilize svn loader implementation.

This PDF contains my SVN Loader review report.

Dec 16 2021, 3:58 PM · SVN Loader, Archive coverage
stsp added inline comments to D6823: validate input paths in the CVS loader.
Dec 16 2021, 11:37 AM
stsp accepted D6849: swh.loader.cvs.tasks: Fix parameter uses to the ones needed.
Dec 16 2021, 11:33 AM

Dec 10 2021

stsp updated the diff for D6823: validate input paths in the CVS loader.
  • add missing check for "/../" to the rcsparse code path
Dec 10 2021, 3:05 PM
stsp added a comment to T3691: Implement CVS loader.

I found one additional problem. See D6823.

Dec 10 2021, 3:01 PM · Loader-CVS, Archive coverage
stsp requested review of D6823: validate input paths in the CVS loader.
Dec 10 2021, 3:01 PM
stsp added a revision to T3691: Implement CVS loader: D6823: validate input paths in the CVS loader.
Dec 10 2021, 3:00 PM · Loader-CVS, Archive coverage
stsp added a comment to T3691: Implement CVS loader.

Unless I have overlooked something, all currently known issues have now been addressed.

Dec 10 2021, 11:40 AM · Loader-CVS, Archive coverage
stsp closed D6813: fix Log keyword expansion with trailing whitespace in prefix.
Dec 10 2021, 11:34 AM
stsp committed rDLDCVSa66c6b4937d4: fix Log keyword expansion with trailing whitespace in prefix (authored by stsp).
fix Log keyword expansion with trailing whitespace in prefix
Dec 10 2021, 11:34 AM
stsp added inline comments to D6813: fix Log keyword expansion with trailing whitespace in prefix.
Dec 10 2021, 11:32 AM

Dec 9 2021

stsp added a revision to T3691: Implement CVS loader: D6813: fix Log keyword expansion with trailing whitespace in prefix.
Dec 9 2021, 3:48 PM · Loader-CVS, Archive coverage
stsp added a task to D6813: fix Log keyword expansion with trailing whitespace in prefix: T3691: Implement CVS loader.
Dec 9 2021, 3:48 PM
stsp requested review of D6813: fix Log keyword expansion with trailing whitespace in prefix.
Dec 9 2021, 3:47 PM
stsp closed D6791: support custom keywords during rsync:// conversion.
Dec 9 2021, 3:33 PM
stsp committed rDLDCVSdcb895ca2ff1: support custom keywords during rsync:// conversion (authored by stsp).
support custom keywords during rsync:// conversion
Dec 9 2021, 3:33 PM
stsp updated the diff for D6791: support custom keywords during rsync:// conversion.

integrate tweaks suggested by vlorentz and squash commits

Dec 9 2021, 3:30 PM
stsp added a comment to T3691: Implement CVS loader.

I have started test conversions of the OpenBSD CVS repository.

Dec 9 2021, 3:21 PM · Loader-CVS, Archive coverage

Dec 8 2021

stsp requested review of D6791: support custom keywords during rsync:// conversion.
Dec 8 2021, 6:09 PM
stsp added a revision to T3691: Implement CVS loader: D6791: support custom keywords during rsync:// conversion.
Dec 8 2021, 3:53 PM · Loader-CVS, Archive coverage
stsp closed D6781: fix the top-level directory path of imported CVS modules.
Dec 8 2021, 12:14 PM
stsp committed rDLDCVS965629d6c8b3: fix the top-level directory path of imported CVS modules (authored by stsp).
fix the top-level directory path of imported CVS modules
Dec 8 2021, 12:14 PM
stsp added inline comments to D6781: fix the top-level directory path of imported CVS modules.
Dec 8 2021, 11:13 AM
stsp requested review of D6781: fix the top-level directory path of imported CVS modules.
Dec 8 2021, 10:01 AM
stsp added a revision to T3691: Implement CVS loader: D6781: fix the top-level directory path of imported CVS modules.
Dec 8 2021, 9:51 AM · Loader-CVS, Archive coverage

Dec 7 2021

stsp committed rDSNIP6a2068dfbf39: add swh-log-oneline.py; displays a one-line summary for each revision in history (authored by stsp).
add swh-log-oneline.py; displays a one-line summary for each revision in history
Dec 7 2021, 12:11 PM
stsp closed D6715: add two example scripts to the snippets repository.
Dec 7 2021, 12:11 PM
stsp committed rDSNIPb64f95c0a265: add swh-diff.py; displays SWH revision changes as a unified diff (authored by stsp).
add swh-diff.py; displays SWH revision changes as a unified diff
Dec 7 2021, 12:11 PM
stsp closed D6762: update test suite documentation.
Dec 7 2021, 11:58 AM
stsp committed rDLDCVS9e8f931ef786: update test suite documentation (authored by stsp).
update test suite documentation
Dec 7 2021, 11:58 AM
stsp added inline comments to D6715: add two example scripts to the snippets repository.
Dec 7 2021, 11:52 AM
stsp requested review of D6762: update test suite documentation.
Dec 7 2021, 11:44 AM
stsp added a revision to T3691: Implement CVS loader: D6762: update test suite documentation.
Dec 7 2021, 11:43 AM · Loader-CVS, Archive coverage
stsp closed D6758: make CVS loader create one snapshot per visit.
Dec 7 2021, 11:26 AM
stsp committed rDLDCVS5298a8f9500e: make CVS loader create one snapshot per visit (authored by stsp).
make CVS loader create one snapshot per visit
Dec 7 2021, 11:26 AM
stsp requested review of D6758: make CVS loader create one snapshot per visit.
Dec 7 2021, 11:00 AM
stsp added a revision to T3691: Implement CVS loader: D6758: make CVS loader create one snapshot per visit.
Dec 7 2021, 10:59 AM · Loader-CVS, Archive coverage
stsp closed D6745: fix expansion of the Log keyword with rsync origins.
Dec 7 2021, 9:53 AM
stsp committed rDLDCVS099959bbfa73: fix expansion of the Log keyword with rsync origins (authored by stsp).
fix expansion of the Log keyword with rsync origins
Dec 7 2021, 9:53 AM
stsp updated the diff for D6745: fix expansion of the Log keyword with rsync origins.

remove unnecessary tweaking of final \n in log buffer

Dec 7 2021, 9:30 AM
stsp added inline comments to D6745: fix expansion of the Log keyword with rsync origins.
Dec 7 2021, 9:29 AM

Dec 6 2021

stsp updated the diff for D6745: fix expansion of the Log keyword with rsync origins.

fix typo in comment

Dec 6 2021, 11:31 AM
stsp updated the diff for D6745: fix expansion of the Log keyword with rsync origins.

addressed review comments; see my responses to various comments for details

Dec 6 2021, 11:29 AM
stsp added inline comments to D6745: fix expansion of the Log keyword with rsync origins.
Dec 6 2021, 11:27 AM
stsp added inline comments to D6745: fix expansion of the Log keyword with rsync origins.
Dec 6 2021, 11:23 AM

Dec 4 2021

stsp requested review of D6745: fix expansion of the Log keyword with rsync origins.
Dec 4 2021, 7:06 PM
stsp added a revision to T3691: Implement CVS loader: D6745: fix expansion of the Log keyword with rsync origins.
Dec 4 2021, 5:39 PM · Loader-CVS, Archive coverage
stsp closed D6585: in cvs loader tests, use f-strings to build repository URLs.
Dec 4 2021, 5:37 PM
stsp committed rDLDCVSf36332c7e376: in cvs loader tests, use f-strings to build repository URLs (authored by stsp).
in cvs loader tests, use f-strings to build repository URLs
Dec 4 2021, 5:36 PM
stsp closed D6708: fix expansion of multiple RCS keywords on a line via rsync.
Dec 4 2021, 5:29 PM
stsp committed rDLDCVS939dd546b050: fix expansion of multiple RCS keywords on a line via rsync (authored by stsp).
fix expansion of multiple RCS keywords on a line via rsync
Dec 4 2021, 5:29 PM
stsp added a comment to D6708: fix expansion of multiple RCS keywords on a line via rsync.

I guess it's currently limited to deal with "only" a 2 keywords in the same line case.
And we'll try and fix futher if any other cases is detected later.

Dec 4 2021, 5:28 PM
stsp added inline comments to D6708: fix expansion of multiple RCS keywords on a line via rsync.
Dec 4 2021, 4:33 PM

Dec 1 2021

stsp requested review of D6715: add two example scripts to the snippets repository.
Dec 1 2021, 4:11 PM

Nov 29 2021

stsp added a revision to T3691: Implement CVS loader: D6708: fix expansion of multiple RCS keywords on a line via rsync.
Nov 29 2021, 7:11 PM · Loader-CVS, Archive coverage
stsp added a task to D6708: fix expansion of multiple RCS keywords on a line via rsync: T3691: Implement CVS loader.
Nov 29 2021, 7:11 PM
stsp requested review of D6708: fix expansion of multiple RCS keywords on a line via rsync.
Nov 29 2021, 6:35 PM
stsp committed rDLDCVSbc00d6b16979: add a test for conversion of a file which contains a Header keyword (authored by stsp).
add a test for conversion of a file which contains a Header keyword
Nov 29 2021, 2:36 PM
stsp closed D6678: attempt to avoid content differences due to paths in keywords.
Nov 29 2021, 2:36 PM
stsp committed rDLDCVS5539ccb67b2a: attempt to avoid content differences due to paths in keywords (authored by stsp).
attempt to avoid content differences due to paths in keywords
Nov 29 2021, 2:36 PM

Nov 26 2021

stsp added a comment to D6678: attempt to avoid content differences due to paths in keywords.
In D6678#174111, @stsp wrote:
  • add a test for conversion of a file which contains a Header keyword
Nov 26 2021, 3:35 PM
stsp updated the diff for D6678: attempt to avoid content differences due to paths in keywords.
  • add a test for conversion of a file which contains a Header keyword
Nov 26 2021, 3:34 PM
stsp added a comment to D6678: attempt to avoid content differences due to paths in keywords.
In D6678#174093, @stsp wrote:

And since our tests control the absolute paths to the test repositories they also control the expanded value of keywords like $Header$.
This means the tests would pass even without this fix in place. So I am not sure such a test would really be meaningful.

Nov 26 2021, 2:55 PM
stsp added a comment to D6678: attempt to avoid content differences due to paths in keywords.
In D6678#174093, @stsp wrote:

This means the tests would pass even without this fix in place. So I am not sure such a test would really be meaningful.

Nov 26 2021, 2:53 PM
stsp added a comment to D6678: attempt to avoid content differences due to paths in keywords.

wow...

Good catch, thanks. Could you add a test for this (so we don't accidentally change it if we ever refactor the loader in the future)?

Nov 26 2021, 2:50 PM

Nov 25 2021

stsp abandoned D6684: fix regular expression used for matching RCS keywords.

This patch is wrong. Keywords stored in already-expanded form in the repository are no longer being expanded. We need a different fix for this issue.

Nov 25 2021, 10:34 AM

Nov 24 2021

stsp requested review of D6684: fix regular expression used for matching RCS keywords.
Nov 24 2021, 12:31 PM
stsp added a revision to T3691: Implement CVS loader: D6684: fix regular expression used for matching RCS keywords.
Nov 24 2021, 12:30 PM · Loader-CVS, Archive coverage
stsp added a task to D6678: attempt to avoid content differences due to paths in keywords: T3691: Implement CVS loader.
Nov 24 2021, 12:30 PM
stsp added a revision to T3691: Implement CVS loader: D6678: attempt to avoid content differences due to paths in keywords.
Nov 24 2021, 12:30 PM · Loader-CVS, Archive coverage
stsp added a comment to T3691: Implement CVS loader.

D6684 addresses another keyword expansion issue found while testing conversion of CVS's own history.

Nov 24 2021, 12:30 PM · Loader-CVS, Archive coverage
stsp requested review of D6678: attempt to avoid content differences due to paths in keywords.
Nov 24 2021, 10:54 AM
stsp added a comment to T3691: Implement CVS loader.

The above problem with the Header keyword can be worked around (at least for the GNU savannah site) with the patch in D6678.

Nov 24 2021, 10:53 AM · Loader-CVS, Archive coverage

Nov 22 2021

stsp closed D6638: preserve empty lines in CVS log messages over pserver.
Nov 22 2021, 7:51 PM
stsp committed rDLDCVS34f46486f4a4: preserve empty lines in CVS log messages over pserver (authored by stsp).
preserve empty lines in CVS log messages over pserver
Nov 22 2021, 7:51 PM

Nov 12 2021

stsp added a comment to T3691: Implement CVS loader.

Another problem with keyword expansion found during testing:

Nov 12 2021, 11:41 AM · Loader-CVS, Archive coverage
stsp added a revision to T3691: Implement CVS loader: D6638: preserve empty lines in CVS log messages over pserver.
Nov 12 2021, 11:38 AM · Loader-CVS, Archive coverage
stsp added a task to D6638: preserve empty lines in CVS log messages over pserver: T3691: Implement CVS loader.
Nov 12 2021, 11:38 AM

Nov 11 2021

stsp requested review of D6638: preserve empty lines in CVS log messages over pserver.
Nov 11 2021, 11:31 AM

Nov 10 2021

stsp added a comment to T3691: Implement CVS loader.
In T3691#73518, @stsp wrote:

There is another problem related to keywords: Some CVS-based projects use custom keywords, instead of the standard $Id$ keyword. This prevents wrong expansion of $Id$ when code is imported from one project to another. Usually the project's name will be used as the custom keyword name, such as $OpenBSD$ or $NetBSD$, instead of $Id$. At present, to expand keywords correctly in this case, we need to use the pserver access method to benefit from server-side keyword expansion. But we will end up with different hashes if rsync is used to import the same origin again. We might be able to auto-detect use of custom keywords if the rsync server allows access to the CVSROOT folder, but this is not always the case. If CVSROOT is hidden from rsync, the only reliable way to detect custom keywords would be a parameter that gets passed into the loader. We could, for example, allow passing the name of a custom keyword as a parameter embedded in the origin URL.

Nov 10 2021, 1:12 PM · Loader-CVS, Archive coverage
stsp closed D6623: add CVS commit ID support to rlog.py.
Nov 10 2021, 12:09 PM
stsp committed rDLDCVSf5b974a00951: add CVS commit ID support to rlog.py (authored by stsp).
add CVS commit ID support to rlog.py
Nov 10 2021, 12:09 PM

Nov 9 2021

stsp updated the diff for D6623: add CVS commit ID support to rlog.py.

changes suggested by vlorentz

Nov 9 2021, 4:03 PM
stsp closed D6593: handle Attic-only RCS files over CVS pserver.
Nov 9 2021, 3:54 PM
stsp committed rDLDCVSd28a4b21c56a: handle Attic-only RCS files over CVS pserver (authored by stsp).
handle Attic-only RCS files over CVS pserver
Nov 9 2021, 3:54 PM
stsp updated the diff for D6593: handle Attic-only RCS files over CVS pserver.

rebased patch

Nov 9 2021, 3:51 PM
stsp closed D6592: improve test coverage of file additions and deletions.
Nov 9 2021, 3:50 PM
stsp committed rDLDCVSd72f15f24dbd: improve test coverage of file additions and deletions (authored by stsp).
improve test coverage of file additions and deletions
Nov 9 2021, 3:50 PM
stsp updated the diff for D6592: improve test coverage of file additions and deletions.

rebased patch

Nov 9 2021, 3:48 PM
stsp closed D6591: display file state in progress logging output.
Nov 9 2021, 3:47 PM
stsp committed rDLDCVSca23bc13c21b: display file state in progress logging output (authored by stsp).
display file state in progress logging output
Nov 9 2021, 3:47 PM