Hey @faux it's the same as T3145

It has been deployed to production, closing this.

In T3078#61841, @KShivendu wrote:

Hey @sdruskat, I have a few questions : (1) Any idea of when will be the new version available and (2) when will be the crosswalk file updated to at least 1.1.0? (3) The newer version will be backwards compatible, right?

Thanks

Hey, can I take this task up next?

Great!

Thanks @faux, it will be deployed with next swh-web release.

Hey @KShivendu,
These are very good observation.

Ok cool.

so for a user having an id like this in the tooltip would feel like an arbitrary string

I had one doubt regarding this, so if the target_type is content then the target would be the content_id, right? But the ids are like this "8e5adfbd7e605bda9c5e96c10e015b3dc0df688e" so for a user having an id like this in the tooltip would feel like an arbitrary string.

Hmmm it's not exactly an alias. <release_name> is actually a reference that can point to a branch :|

release: "The release <release_name> is an alias for release <target_release_id>"

Cool, makes sense. Will work on it and create a diff.

I think label and commit picto dont make sense.

@KShivendu The linked script is a start. As it is, it requires direct access to the DB; so you need to create abstractions for it in swh-storage and swh-web

ok, thanks. It's actually tested in test_stat_counters in swh-storage/swh/storage/tests/storage_tests.py, which is used to test all four classes.

Pass an object without `unique_key` and check it does raise an exception

Run the nixguix loader with url=https://guix.gnu.org/sources.json, you'll get a bunch of ftp-related errors. eg. this one https://sentry.softwareheritage.org/share/issue/7dc92745d96442d482a493c64b6eae91/

Hi, I would like to take up this task. What should the tooltips be, to me also I think label and commit picto dont make sense.

Hi guys. Any pointers on where to start?

I might be wrong but, I think it has been completed. Check out these :

Hey @moranegg
I suggest the following modifications in adding-support-for-additional-metadata page:

• python3 -m swh.indexer.metadata_dictionary MyMapping path/to/input/file doesn't work. Replace with swh indexer mapping translate cff path/to/input/file
• Whenever adding new mappings, it has to be mentioned in the MAPPING_NAME variable of the swh/indexer/storage/__init__.py file which isn't mentioned in the documentation. (though it didn't throw error while testing or parsing) and in expected_output of test_cli_mapping_list
• Mentioning a few examples about fields that are not string_fields
• Elaborating how _traslate_dict function works. For example : it executes functions starting with 'normalize_'
• Mention command : swh indexer mapping list-terms to display Supported CodeMeta terms
• Add Youtube videos about JSONLD : JSON-LD Basics, JSON-LD: Core markup, Compaction and Expansion

I am here to just say: swh-loader-git doesn't have a CONTRIBUTORS file. You may ask the contributor to add it as well :)

Hey @vlorentz
How do I check https://forge.softwareheritage.org/source/swh-journal/browse/master/swh/journal/writer/inmemory.py$31. Do I have to pass dummy content, raw_extrinsic_metadata, origin_visit, et cetera as the object_ to write_addition function and before passing verify if they have unique_key function implemented ?

Hey @vlorentz, can you please give me some hints for this and an example URL for testing the code?

Hi @zack Is this task still valid? If so how do I reproduce the error. I tried running pytest in swh-fuse and swh-core but that doesn't throw any error.

You can check if there is currently some warnings issued during the documentation build by following this link. Every reported warnings should be fixed.

No longer relevant

Raw extract data [1] of both deposit with status done and those joined as pastes:

• deposit-ipol.done.csv: P999
• deposit-ipol.not-done.csv: P1000

Hey @sdruskat, I have a few questions : (1) Any idea of when will be the new version available and (2) when will be the crosswalk file updated to at least 1.1.0? (3) The newer version will be backwards compatible, right?

Hey @KShivendu, thanks, sounds good. Let me know if you have any questions.

Hey @sdruskat, I noticed that the current crosswalk.csv has CFF version 1.0.2. And I agree on keeping the crosswalk.csv file updated as much as possible. But to the best of my knowledge, updating the crosswalk.csv file later (when you are done with creating the new version) won't break anything here. Plus, I am new here and I am learning about metadata which is helping me write a better GSoC proposal.
Also, I can assure you that I will update the crosswalk.csv file myself if you want :)

Hello again, seeing that you had asked about the crosswalk @KShivendu, and that we're currently in the process of creating a new CFF version, may I suggest that we put this on hold until we have at least updated the crosswalk to the currently latest version of CFF, 1.1.0?

ohh allright.

@shashikant231 please do not claim tasks. Just submit a diff fixing the issue when you have one. Thanks.

Dear @Kaustuv942, sure, patches welcome. We do not use task claiming for non regular contributors though, just submit a patch when you have one.

Hello @zack I want to complete this task.

@shashikant231 the goal is to add type annotations to all functions arguments and return type in the swh/loader/svn/ package. See https://mypy.readthedocs.io/ for an introduction to type annotations in python if you have never used them before

Hi @vlorentz This is my first issue with this organization. can you plz describe in more detail?

In the task description there are two links, one to a blog post and another to the documentation.
If the docs aren't specific enough to complete the task, let us know, what is missing.
I prefer not to give further instructions to really see what is the limit of the documentation.
We are also trying to improve the documentation, so this would be a win win.

In T1475#27210, @vlorentz wrote:

" AttributeError on @id with a colon but less than two slashes" https://github.com/digitalbazaar/pyld/issues/91

Hey @moranegg I had a discussion yesterday with @vlorentz on this. We came to the conclusion that the cff-converter should be used as it might cover some edge cases as well. So what should we do now? Please guide.

Hi @KShivendu, nice to see you claimed the task :-)
You don't have to use the cff-converter tool, but it can be a test (to ensure coherence).

Fixed by D5182 and D5183, closing this as resolved.