Files in swh/indexer/metadata_dictionary/ currently do not have any type annotation. It would be nice to annotate all their functions.
Description
Description
Revisions and Commits
Revisions and Commits
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Migrated | gitlab-migration | T2221 Development workflow & code quality | ||
| Migrated | gitlab-migration | T2223 Type checking | ||
| Migrated | gitlab-migration | T2257 Fully annotate swh-indexer with types | ||
| Migrated | gitlab-migration | T2259 Add type annotations to metadata mappings |
Event Timeline
Comment Actions
Hi @vlorentz this will be my first contribution for Software Heritage so can you explain about the issue a little more. Also I am having some problems installing Arcanist (fatal error with php not getting resolved)into my system. Will it be possible to commit directly on github.
Comment Actions
so can you explain about the issue a little more
The linked document should explain what type annotations are in Python; is there something you need help with?
Also I am having some problems installing Arcanist (fatal error with php not getting resolved)into my system.
Join the chat so we can try to help you
Will it be possible to commit directly on github.
No; we only have read-only mirrors on github, the actual development is here.
Comment Actions
While annotating, are we expected to use native Python Datatypes (like str, int, float etc.) or do I use the NewType class of the Type library as in the example below:
from typing import NewType
UserId = NewType('UserId', int)
some_id = UserId(524313)