Page MenuHomeSoftware Heritage

rohan-sachan (Rohan Sachan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 13 2021, 2:03 AM (28 w, 2 d)

Recent Activity

Mar 25 2021

rohan-sachan added a comment to D5295: Add type annotations to metadata mappings.

Ok, I'll give another try at rectifying these issues throughout all the files.
Just a quick question, did you review the changes for all the files, or did you review the changes only up to base.py and didn't review further because of the repeated issues?

Mar 25 2021, 5:01 PM

Mar 24 2021

rohan-sachan added a comment to D5295: Add type annotations to metadata mappings.

@ardumont : Ok, removed the suffix "Closes T2259" from DIff title and summary.

Mar 24 2021, 4:31 PM
rohan-sachan retitled D5295: Add type annotations to metadata mappings from Add type annotations to metadata mappings Closes T2259 to Add type annotations to metadata mappings.
Mar 24 2021, 4:18 PM
rohan-sachan updated the diff for D5295: Add type annotations to metadata mappings.

Change type annotations to more concrete type
Change Type annotations for all files in swh.indexer.metadata_mapping to reflect more concrete type annotations.
Remove unncesseary usage of # type: ignore

Mar 24 2021, 4:07 PM

Mar 21 2021

rohan-sachan added a comment to D5295: Add type annotations to metadata mappings.

Thanks for a prompt review.
I'll go level deeper into annotating wherever I have used Any, and wherever it's possible to go a level deeper. Will submit an updated diff by tomorrow.

Mar 21 2021, 10:18 PM
rohan-sachan retitled D5295: Add type annotations to metadata mappings from Added type annotations to metadata mappings Closes T2259 to Add type annotations to metadata mappings Closes T2259.
Mar 21 2021, 2:32 PM
rohan-sachan added a reviewer for D5295: Add type annotations to metadata mappings: vlorentz.
Mar 21 2021, 1:52 PM
rohan-sachan requested review of D5295: Add type annotations to metadata mappings.
Mar 21 2021, 1:44 PM
rohan-sachan added a revision to T2259: Add type annotations to metadata mappings: D5295: Add type annotations to metadata mappings.
Mar 21 2021, 1:41 PM · Easy hack, Indexer