Page MenuHomeSoftware Heritage

Add type annotations to swh.loaders.svn
Open, NormalPublic

Description

swh-loader-svn is in dire need of annotations (and some docstrings and variable names updates, as they haven't kept up with refactoring)

It should probably start with a Diff to fully annotate swh/loader/svn/svn.py as it's the "source" of most objects manipulated by the package, then one or more Diffs to the rest of the package.

Event Timeline

vlorentz triaged this task as Normal priority.Mar 16 2021, 11:50 AM
vlorentz created this task.
shashikant231 added a subscriber: shashikant231.

Hi @vlorentz This is my first issue with this organization. can you plz describe in more detail?

Thanks!

@shashikant231 the goal is to add type annotations to all functions arguments and return type in the swh/loader/svn/ package. See https://mypy.readthedocs.io/ for an introduction to type annotations in python if you have never used them before

@shashikant231 please do not claim tasks. Just submit a diff fixing the issue when you have one. Thanks.