Page MenuHomeSoftware Heritage

swh-core: missing test dependency on requests
Closed, MigratedEdits Locked

Description

In a brand new python module that depends only on swh-core, pytest fails as:

  File "/home/zack/dati/projects/sw-heritage/git/swh-environment/swh-fuse/.tox/py3/lib/python3.8/site-packages/swh/core/pytest_plugin.py", line 9, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'

and indeed that plugin depends on requests.

I think this means that an explicit test-time dependency on requests is missing from swh-core.

Event Timeline

zack triaged this task as Low priority.Sep 23 2020, 2:23 PM
zack created this task.
zack edited projects, added Core & foundations; removed Core Loader.
zack added a project: Easy hack.

Hi @zack Is this task still valid? If so how do I reproduce the error. I tried running pytest in swh-fuse and swh-core but that doesn't throw any error.