Page MenuHomeSoftware Heritage

seirl (Antoine Pietri)
User

User Details

User Since
Feb 2 2017, 11:38 AM (303 w, 6 d)

Recent Activity

Oct 25 2022

seirl added a comment to T4644: replayer crashes on invalid directory entry name (b'gitter/gitter.xml').

Oh yeah, I was thinking of just removing the entire project, but your solution also works.

Oct 25 2022, 6:15 PM · Archive integrity, Object storage, Data Model
seirl added a comment to T4644: replayer crashes on invalid directory entry name (b'gitter/gitter.xml').

Do you actually want to keep these objects? This would be inconsistent with the fixed loader behavior that would just reject those objects, and not load the repository at all.

Oct 25 2022, 6:06 PM · Archive integrity, Object storage, Data Model

Oct 20 2022

seirl edited P1502 GRPC python client example.
Oct 20 2022, 5:14 PM
seirl created P1502 GRPC python client example.
Oct 20 2022, 5:13 PM

Sep 12 2022

seirl added a project to T4418: GRPC node streams contain successor{} repeated field even when masked out: Compressed graph service.
Sep 12 2022, 5:28 PM · Compressed graph service

Aug 4 2022

seirl edited P1415 (An Untitled Masterwork).
Aug 4 2022, 11:52 PM
seirl edited P1415 (An Untitled Masterwork).
Aug 4 2022, 11:47 PM
seirl created P1415 (An Untitled Masterwork).
Aug 4 2022, 11:44 PM
seirl requested review of D8191: Add a flyweight copy() to SwhGraphProperties to make it threadsafe.
Aug 4 2022, 6:12 PM
seirl added a comment to T4422: Graph property access is not thread-safe.

Partially solved by https://forge.softwareheritage.org/D8191

Aug 4 2022, 6:06 PM · Compressed graph service
seirl added a comment to T4422: Graph property access is not thread-safe.

Opened https://github.com/vigna/dsiutils/pull/6 as a potential fix for https://github.com/vigna/dsiutils/issues/5

Aug 4 2022, 6:00 PM · Compressed graph service
seirl updated the task description for T4422: Graph property access is not thread-safe.
Aug 4 2022, 5:26 PM · Compressed graph service
seirl triaged T4422: Graph property access is not thread-safe as High priority.
Aug 4 2022, 1:54 PM · Compressed graph service

Aug 3 2022

seirl triaged T4419: LabelMapBuilder is not properly documented as Normal priority.
Aug 3 2022, 7:00 PM · Compressed graph service
seirl triaged T4418: GRPC node streams contain successor{} repeated field even when masked out as Normal priority.
Aug 3 2022, 6:59 PM · Compressed graph service
seirl created T4418: GRPC node streams contain successor{} repeated field even when masked out.
Aug 3 2022, 6:59 PM · Compressed graph service
seirl triaged T4417: Verbose logging for graph property loading as Normal priority.
Aug 3 2022, 6:57 PM · Compressed graph service
seirl created T4417: Verbose logging for graph property loading.
Aug 3 2022, 6:56 PM · Compressed graph service

Jul 7 2022

seirl closed D8090: Update dataset page with 2022 export.
Jul 7 2022, 2:04 PM
seirl committed rDDATASETc8e77380e135: Update dataset page with 2022 export (authored by seirl).
Update dataset page with 2022 export
Jul 7 2022, 2:04 PM

Jul 6 2022

seirl updated the diff for D8090: Update dataset page with 2022 export.

Fix URL

Jul 6 2022, 7:53 PM
seirl requested review of D8090: Update dataset page with 2022 export.
Jul 6 2022, 7:37 PM

Jul 5 2022

seirl closed D8064: swh-graph: rename services (now production-ready, no longer dev).
Jul 5 2022, 6:49 PM
seirl committed rSPSITEb10a8070501c: swh-graph: rename services (now production-ready, no longer dev) (authored by seirl).
swh-graph: rename services (now production-ready, no longer dev)
Jul 5 2022, 6:49 PM
seirl updated the diff for D8064: swh-graph: rename services (now production-ready, no longer dev).

fix service path + rebase

Jul 5 2022, 12:08 PM

Jun 30 2022

seirl committed rDGRPH555e3b6d3e11: rpc_server: use shlex.quote() to print command (authored by seirl).
rpc_server: use shlex.quote() to print command
Jun 30 2022, 8:49 PM
seirl committed rDGRPHa55edc1f88d5: Remove shlex.join() call (3.8 only) (authored by seirl).
Remove shlex.join() call (3.8 only)
Jun 30 2022, 8:33 PM
seirl committed rDGRPH94418d4944a8: GRPC: use port 50091 by default (authored by seirl).
GRPC: use port 50091 by default
Jun 30 2022, 8:07 PM
seirl committed rDGRPH441aacc6aeeb: Update sux4j to 5.4.0 (authored by seirl).
Update sux4j to 5.4.0
Jun 30 2022, 8:07 PM
seirl requested review of D8064: swh-graph: rename services (now production-ready, no longer dev).
Jun 30 2022, 7:15 PM
seirl committed rDGRPH26e52b389fb1: rpc_server.py: terminate, then kill server on timeout (authored by seirl).
rpc_server.py: terminate, then kill server on timeout
Jun 30 2022, 6:59 PM
seirl added a comment to T3259: Gracefully handle a client closing the connection in the middle of a response being streamed.

GRPC update: cancelling a GRPC stream works fine, but it doesn't seem like aiohttp is doing that when the HTTP stream is closed.

Jun 30 2022, 6:41 PM · Compressed graph service
seirl closed T4316: Push of swh-graph to pypi is broken as Resolved.

We requested a larger quota here: https://github.com/pypa/pypi-support/issues/1998

Jun 30 2022, 5:37 PM · System administration, Compressed graph service
seirl committed rDGRPHf2f9e8ba69ef: DumpProperties: fix output for tag names (authored by seirl).
DumpProperties: fix output for tag names
Jun 30 2022, 5:18 PM
seirl closed D8061: Re-add swh/graph/client.py for backward-compatibility.
Jun 30 2022, 4:48 PM
seirl committed rDGRPH3b9685923021: Re-add swh/graph/client.py for backward-compatibility (authored by seirl).
Re-add swh/graph/client.py for backward-compatibility
Jun 30 2022, 4:48 PM
seirl requested review of D8061: Re-add swh/graph/client.py for backward-compatibility.
Jun 30 2022, 4:44 PM
seirl closed T2100: Bootstrap Debian packaging for swh.graph, a subtask of T3168: Proper deployment of swh-graph with debian package, as Wontfix.
Jun 30 2022, 4:21 PM · Compressed graph service, Puppet recipes
seirl closed T2100: Bootstrap Debian packaging for swh.graph as Wontfix.

We are migrating away from Debian packages as a deployment tool, closing this as WONTFIX.

Jun 30 2022, 4:21 PM · Compressed graph service
seirl closed T3168: Proper deployment of swh-graph with debian package as Wontfix.

We are migrating away from Debian packages as a deployment tool, closing this as WONTFIX.

Jun 30 2022, 4:20 PM · Compressed graph service, Puppet recipes
seirl closed T2081: swh-graph: "Cannot open client FIFO" when answering HEAD requests as Resolved.

No longer happens after the GRPC migration:

Jun 30 2022, 4:19 PM · Compressed graph service
seirl closed T2103: (Debian) package py4j, a subtask of T2100: Bootstrap Debian packaging for swh.graph, as Wontfix.
Jun 30 2022, 4:16 PM · Compressed graph service
seirl closed T2103: (Debian) package py4j as Wontfix.

We removed the Py4J dependency by migrating to GRPC.

Jun 30 2022, 4:16 PM · Compressed graph service
seirl closed T3301: graph: add test for the "algo" parameter of walk() as Wontfix.

We no longer support multiple algorithms for shortest path requests.

Jun 30 2022, 4:16 PM · Easy hack, Compressed graph service
seirl closed T3623: Run swh-graph with gunicorn to support multiple/parallel requests as Resolved.

Obsoleted by the migration to GRPC. Now we use GRPC's threading model, with a threadpool configurable by passing --threads to the Java service. By default, nproc is used.

Jun 30 2022, 4:12 PM · Compressed graph service, System administration
seirl closed D8059: Generate .labelobl files to speed-up labelled graph loading.
Jun 30 2022, 4:11 PM
seirl committed rDGRPH32f2626a7d0a: Generate .labelobl files to speed-up labelled graph loading (authored by seirl).
Generate .labelobl files to speed-up labelled graph loading
Jun 30 2022, 4:11 PM
seirl closed T4113: Review border case of empty response for `visit_nodes` as Resolved.

Obsoleted by the migration to GRPC. We no longer create iterators on the decoded stream of a UNIX pipeline, we directly use GRPC stream iterators.

Jun 30 2022, 4:11 PM · Compressed graph service
seirl closed T4115: Some unknown SWHID errors crash the graph server as Resolved.

Fixed by the migration to GRPC.

Jun 30 2022, 4:08 PM · Compressed graph service
seirl updated the diff for D8059: Generate .labelobl files to speed-up labelled graph loading.

rebase

Jun 30 2022, 4:02 PM
seirl updated the diff for D8059: Generate .labelobl files to speed-up labelled graph loading.
  • Generate .labelobl files to speed-up labelled graph loading
Jun 30 2022, 4:02 PM
seirl committed rDGRPH795fa182f212: docs: remove relative include of swhgraph.proto (authored by seirl).
docs: remove relative include of swhgraph.proto
Jun 30 2022, 3:59 PM
seirl created P1397 (An Untitled Masterwork).
Jun 30 2022, 3:48 PM
seirl requested review of D8059: Generate .labelobl files to speed-up labelled graph loading.
Jun 30 2022, 3:37 PM
seirl committed rDGRPH5c3f59ecfe52: Rename Node.Type enum to SwhType (authored by seirl).
Rename Node.Type enum to SwhType
Jun 30 2022, 3:28 PM
seirl closed T3793: Add copyright notices to all swh-graph Java files as Resolved.

Fixed in D8050

Jun 30 2022, 2:28 PM · Compressed graph service

Jun 29 2022

seirl closed D8050: Add missing copyright notices to the entire Java codebase.
Jun 29 2022, 9:46 PM
seirl committed rDGRPHd5a07973b1be: Add missing copyright notices to the entire Java codebase (authored by seirl).
Add missing copyright notices to the entire Java codebase
Jun 29 2022, 9:46 PM
seirl updated the diff for D8050: Add missing copyright notices to the entire Java codebase.

Fix ranges

Jun 29 2022, 3:24 PM
seirl added a revision to T3793: Add copyright notices to all swh-graph Java files: D8050: Add missing copyright notices to the entire Java codebase.
Jun 29 2022, 3:07 PM · Compressed graph service
seirl committed rDGRPH066edad7cc36: SwhGraphProperties: remove useless IOExceptions (authored by seirl).
SwhGraphProperties: remove useless IOExceptions
Jun 29 2022, 12:08 PM
seirl committed rDGRPHb61ca2d1ef44: SwhUnidirectionalGraph: make constructor with properties public (authored by seirl).
SwhUnidirectionalGraph: make constructor with properties public
Jun 29 2022, 12:08 PM
seirl committed rDGRPHfd61a31ef0c4: Add CheckSwhid() and Stats() RPC methods (authored by seirl).
Add CheckSwhid() and Stats() RPC methods
Jun 29 2022, 12:08 PM
seirl committed rDGRPH0b4fd29e3b14: GRPC: initial commit with protobuf + java server (authored by seirl).
GRPC: initial commit with protobuf + java server
Jun 29 2022, 12:08 PM
seirl committed rDGRPH208f5dc60128: Java: add proto/ dir symlink (authored by seirl).
Java: add proto/ dir symlink
Jun 29 2022, 12:08 PM
seirl committed rDGRPHf098232f4282: Python: migrate HTTP API to GRPC (authored by seirl).
Python: migrate HTTP API to GRPC
Jun 29 2022, 12:08 PM
seirl committed rDGRPH431d98de6ae4: RPC: temporarily use loadLabelled() because loadLabelledMapped() doesn't work… (authored by seirl).
RPC: temporarily use loadLabelled() because loadLabelledMapped() doesn't work…
Jun 29 2022, 12:08 PM
seirl committed rDGRPH822f03de2161: Java tests: migrate to GRPC (authored by seirl).
Java tests: migrate to GRPC
Jun 29 2022, 12:08 PM
seirl committed rDGRPH5c08b117f336: Remove old Java HTTP server, replaced by GRPC (authored by seirl).
Remove old Java HTTP server, replaced by GRPC
Jun 29 2022, 12:08 PM
seirl committed rDGRPH9eaccde2cadb: NodeIdMap: use new *MappedBigList classes, remove deprecated classes and MapFile (authored by seirl).
NodeIdMap: use new *MappedBigList classes, remove deprecated classes and MapFile
Jun 29 2022, 12:08 PM
seirl committed rDGRPH6d63a39642ba: Remove now useless dot.py (authored by seirl).
Remove now useless dot.py
Jun 29 2022, 12:08 PM
seirl committed rDGRPHa4d1eb10793f: Remove now useless backend.py (authored by seirl).
Remove now useless backend.py
Jun 29 2022, 12:08 PM
seirl committed rDGRPH4e592de704c7: Reorganize Python files (RPC/HTTP server distinction) (authored by seirl).
Reorganize Python files (RPC/HTTP server distinction)
Jun 29 2022, 12:08 PM
seirl committed rDGRPH5d36ca6eaffa: flake: exclude swh/graph/rpc dir (authored by seirl).
flake: exclude swh/graph/rpc dir
Jun 29 2022, 12:08 PM
seirl committed rDGRPH131e7165ff72: mypy.ini: ignore grpc generated files (authored by seirl).
mypy.ini: ignore grpc generated files
Jun 29 2022, 12:08 PM
seirl committed rDGRPHccc6b295a387: requirements-test: add grpc-stubs (authored by seirl).
requirements-test: add grpc-stubs
Jun 29 2022, 12:08 PM
seirl committed rDGRPHe7fb41e4cd99: Add rpc.StatsTest (authored by seirl).
Add rpc.StatsTest
Jun 29 2022, 12:08 PM
seirl committed rDGRPH3649bd634e61: proto: migrate to FieldMask to filter out fields (authored by seirl).
proto: migrate to FieldMask to filter out fields
Jun 29 2022, 12:08 PM
seirl committed rDGRPHeefdd910c43c: Remove GraphDirection.BOTH (labelled iteration not supported yet) (authored by seirl).
Remove GraphDirection.BOTH (labelled iteration not supported yet)
Jun 29 2022, 12:08 PM
seirl committed rDGRPH383ed27418f9: Add FindPathTo and FindPathBetween endpoints (authored by seirl).
Add FindPathTo and FindPathBetween endpoints
Jun 29 2022, 12:08 PM
seirl committed rDGRPH70fc951eac99: Traversal: test impossible paths (authored by seirl).
Traversal: test impossible paths
Jun 29 2022, 12:08 PM
seirl committed rDGRPHa2c35364b57a: Traversal: check for invalid arguments (authored by seirl).
Traversal: check for invalid arguments
Jun 29 2022, 12:08 PM
seirl committed rDGRPH83be48e06673: Traversal: test traversals from multiple sources/to multiple dests (authored by seirl).
Traversal: test traversals from multiple sources/to multiple dests
Jun 29 2022, 12:08 PM
seirl committed rDGRPH60e93f13390c: Remove CheckSwhid, use GetNode instead (authored by seirl).
Remove CheckSwhid, use GetNode instead
Jun 29 2022, 12:08 PM
seirl committed rDGRPH6e16ec9d7579: Add tests for CountNodes/CountEdges (authored by seirl).
Add tests for CountNodes/CountEdges
Jun 29 2022, 12:08 PM
seirl committed rDGRPHc117623b3c26: Traversal: simplify the StopTraversal logic (authored by seirl).
Traversal: simplify the StopTraversal logic
Jun 29 2022, 12:08 PM
seirl committed rDGRPH9f83ed730669: Traversal: add max depth and common ancestors tests (authored by seirl).
Traversal: add max depth and common ancestors tests
Jun 29 2022, 12:08 PM
seirl committed rDGRPH328f26e31ccf: More protobuf/grpc documentation, better field names (authored by seirl).
More protobuf/grpc documentation, better field names
Jun 29 2022, 12:08 PM
seirl committed rDGRPHc241e13548f2: Traversal: add max edge tests (authored by seirl).
Traversal: add max edge tests
Jun 29 2022, 12:08 PM
seirl committed rDGRPHc7559ac55f7c: Document protobuf/grpc services and fields (authored by seirl).
Document protobuf/grpc services and fields
Jun 29 2022, 12:08 PM
seirl committed rDGRPH2f149363d21f: swhgraph.proto: small documentation fixes (authored by seirl).
swhgraph.proto: small documentation fixes
Jun 29 2022, 12:08 PM
seirl committed rDGRPH98fce8be99f5: Add inline docstrings to Java GRPC server (authored by seirl).
Add inline docstrings to Java GRPC server
Jun 29 2022, 12:08 PM
seirl committed rDGRPHb58cb841b6a1: doc: First full draft of GRPC API documentation (authored by seirl).
doc: First full draft of GRPC API documentation
Jun 29 2022, 12:08 PM
seirl committed rDGRPHe6e6866279da: doc: add GRPC page skeleton (authored by seirl).
doc: add GRPC page skeleton
Jun 29 2022, 12:08 PM
seirl committed rDGRPHab895e3a0b53: Remove old useless classes, including Traversal (authored by seirl).
Remove old useless classes, including Traversal
Jun 29 2022, 12:08 PM
seirl committed rDGRPH3ce74dfd2a01: Regenerate python protobuf documentation (authored by seirl).
Regenerate python protobuf documentation
Jun 29 2022, 12:08 PM
seirl committed rDGRPHa6e02f726926: style: typos and indent fixes (authored by seirl).
style: typos and indent fixes
Jun 29 2022, 12:08 PM
seirl committed rDGRPHd89f35478012: SwhBidirectionalGraph: fix copy() not actually copying subgraphs (authored by seirl).
SwhBidirectionalGraph: fix copy() not actually copying subgraphs
Jun 29 2022, 12:08 PM
seirl committed rDGRPHf528aa80db5b: GetNode: make endpoint thread-safe with a lightweight copy of the graph (authored by seirl).
GetNode: make endpoint thread-safe with a lightweight copy of the graph
Jun 29 2022, 12:08 PM
seirl closed D7890: Migrate low-level RPC API from Py4J to GRPC.
Jun 29 2022, 12:08 PM