- User Since
- Feb 2 2017, 11:38 AM (219 w, 2 d)
Fri, Apr 16
It looks to me like this would be simpler if max_edges was given as a parameter to Traversal, since it's common to most methods. Would that work?
Thu, Apr 15
Wed, Apr 14
Add documentation and licensing info
Thanks for the review!
I just want to write something here that maybe isn't clear from the initial task description. This filtering must happen *after* the visit, not before. We can already change *how* the graph is visited using the edges parameter, the goal of this task is to filter the result post-visit.
Right, I suppose we can close the task then?
Remove debug print
Tue, Apr 13
@zack We talked about this on IRC with @vlorentz, I think this issue is invalid. We chose to have the source and destination nodes as part of the URI in the API. Semantically, it makes sense that accessing the path without these path fragments would return a 404: it's not a missing argument but an invalid path. If we had a ?src= and a &dst= arguments instead, then having a 400 error would make sense, but in our case the semantics are really weird.
Fri, Apr 9
- Fix reviews
- Add backward compatibility for loading MPH on strings
Wed, Apr 7
Duplicate of T2431
I'm not saying the current state of the docs is good enough, I'm saying this commit message doesn't explain the design but why we're moving away from the old binary search solution. The new way of doing things is a lot more natural thing to do since we already have the MPH and the .order file, so there's no need to document why the old solution was bad in the main docs.
Where are the .order and MPH computed?
Thanks for the review. I don't think this needs to be documented elsewhere, it just describes why we're doing the change. What should be documented instead is why we're using these data structures in the first place. Right now this is done sparsely in the different source files, and this commit updates the already existing documentation.
Tue, Apr 6
There's a problem with this diff, it's on an old java-only backend that isn't the one we use when we run swh graph rpc-serve. The one that is currently used is in python, at swh/graph/server/app.py
Fri, Apr 2
Fri, Mar 26
Rebase + fix phabricator incorrect ID
Remove phabricator garbage
The ORC exporter is done, and it's likely that we won't provide CSV exports in the future, or we'll generate them from the ORC format.
Thu, Mar 25
Wed, Mar 24
Tue, Mar 23
Mar 4 2021
Feb 24 2021
Feb 15 2021
Feb 12 2021
I added unit tests and reworked the logic, and also addressed @olasd 's comment. Could you please rereview? :-)