Page MenuHomeSoftware Heritage

Hakimb (Hakim Baaloudj)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 1 2021, 11:29 AM (39 w, 2 d)

Recent Activity

Jun 24 2021

Hakimb updated the diff for D5707: fix the semantic of max_edges parameter.

update a test

Jun 24 2021, 3:18 PM

May 7 2021

Hakimb updated the diff for D5707: fix the semantic of max_edges parameter.

typo

May 7 2021, 2:12 AM
Hakimb updated the diff for D5707: fix the semantic of max_edges parameter.

remove unecessered line on test_api_client

May 7 2021, 2:10 AM
Hakimb updated the diff for D5707: fix the semantic of max_edges parameter.

fix typo and errors

May 7 2021, 2:07 AM
Hakimb added inline comments to D5707: fix the semantic of max_edges parameter.
May 7 2021, 2:03 AM
Hakimb added a comment to D5707: fix the semantic of max_edges parameter.

What is the difference between nbEdgesAccessed and currentEdgeAccessed? It looks like the latter is not used at all (only incremented, but never read), but I may be missing something

I see that in multiple place, you set currentEdgeAccessed = 0; before breaking/returning. What is it for? Is the same instance of Traversal used to serve multiple queries?

May 7 2021, 1:38 AM
Hakimb added inline comments to D5707: fix the semantic of max_edges parameter.
May 7 2021, 1:24 AM

May 6 2021

Hakimb updated the diff for D5707: fix the semantic of max_edges parameter.

change commit name

May 6 2021, 8:51 PM
Hakimb updated the diff for D5707: fix the semantic of max_edges parameter.

squash commits

May 6 2021, 8:49 PM
Hakimb updated the diff for D5707: fix the semantic of max_edges parameter.
  • add all possible values for the request
May 6 2021, 8:46 PM
Hakimb requested review of D5707: fix the semantic of max_edges parameter.
May 6 2021, 8:38 PM

May 4 2021

Hakimb accepted D5672: Traversal: Fix ignored maxEdges being ignored in overloaded constructor..
May 4 2021, 6:17 PM
Hakimb closed D5577: adds a filter by node type as a query argument.
May 4 2021, 5:38 PM
Hakimb committed rDGRPH85880ae74999: adds a filter by node type as a query argument (authored by Hakimb).
adds a filter by node type as a query argument
May 4 2021, 5:38 PM
Hakimb updated the diff for D5577: adds a filter by node type as a query argument.

fix argument in Entry and Traversal + an assert in test_api_client

May 4 2021, 5:31 PM
Hakimb updated the diff for D5577: adds a filter by node type as a query argument.

squash commits

May 4 2021, 5:17 PM
Hakimb updated the diff for D5577: adds a filter by node type as a query argument.

conflicts merge fixed

May 4 2021, 5:03 PM
Hakimb updated the diff for D5577: adds a filter by node type as a query argument.

fix diff

May 4 2021, 4:39 PM
Hakimb updated the diff for D5577: adds a filter by node type as a query argument.
  • fix comment
May 4 2021, 4:33 PM
Hakimb abandoned D5411: return a 400 error when accessing endpoints without the arguments.
May 4 2021, 2:58 PM

Apr 28 2021

Hakimb updated the diff for D5577: adds a filter by node type as a query argument.

rebase and add comments and examples in NodeFiltering class

Apr 28 2021, 1:52 PM
Hakimb updated the diff for D5577: adds a filter by node type as a query argument.
  • add comments and examples in NodeFiltering class
Apr 28 2021, 12:45 PM

Apr 26 2021

Hakimb closed D5501: add an anti-Dos limit for edges traversed as a query parameter.
Apr 26 2021, 2:56 PM
Hakimb committed rDGRPHe8f052a34003: Add an anti DoS limit for edges traversed as a query parameter. (authored by Hakimb).
Add an anti DoS limit for edges traversed as a query parameter.
Apr 26 2021, 2:56 PM

Apr 23 2021

Hakimb updated the diff for D5577: adds a filter by node type as a query argument.

add comment and examples of queries

Apr 23 2021, 6:25 PM
Hakimb updated the diff for D5577: adds a filter by node type as a query argument.

adding comments, tests, and fix code style

Apr 23 2021, 6:11 PM
Hakimb added a comment to D5577: adds a filter by node type as a query argument.
Apr 23 2021, 4:17 PM
Hakimb updated the diff for D5501: add an anti-Dos limit for edges traversed as a query parameter.

change commit name

Apr 23 2021, 2:51 PM

Apr 22 2021

Hakimb updated the diff for D5501: add an anti-Dos limit for edges traversed as a query parameter.

squash

Apr 22 2021, 8:57 PM
Hakimb updated the diff for D5501: add an anti-Dos limit for edges traversed as a query parameter.
  • max_edges argument was missing
Apr 22 2021, 8:51 PM
Hakimb requested review of D5577: adds a filter by node type as a query argument.
Apr 22 2021, 5:29 PM

Apr 21 2021

Hakimb updated the diff for D5501: add an anti-Dos limit for edges traversed as a query parameter.
  • add the maxEdges parameter for leaves and neighbors endpoints
Apr 21 2021, 3:29 PM

Apr 20 2021

Hakimb updated the diff for D5501: add an anti-Dos limit for edges traversed as a query parameter.

squash

Apr 20 2021, 4:48 PM
Hakimb updated the diff for D5501: add an anti-Dos limit for edges traversed as a query parameter.

maxEdges is now a Traversal parameter

Apr 20 2021, 4:29 PM

Apr 16 2021

Hakimb updated the diff for D5501: add an anti-Dos limit for edges traversed as a query parameter.

squashing of commits

Apr 16 2021, 5:38 PM
Hakimb updated the diff for D5501: add an anti-Dos limit for edges traversed as a query parameter.

I fixed the unit tests that didn't work because of the default argument value of max_edges (it was None instead of 0) in graph.py

Apr 16 2021, 2:49 PM
Hakimb updated the diff for D5501: add an anti-Dos limit for edges traversed as a query parameter.

add an anti-Dos limit for edges traversed as a query parameter

Apr 16 2021, 2:04 PM
Hakimb updated the diff for D5501: add an anti-Dos limit for edges traversed as a query parameter.

fix + rebase

Apr 16 2021, 12:50 PM
Hakimb updated the diff for D5501: add an anti-Dos limit for edges traversed as a query parameter.

rebase

Apr 16 2021, 11:29 AM

Apr 15 2021

Hakimb added a comment to D5501: add an anti-Dos limit for edges traversed as a query parameter.

I'm not sure how to fix this problem. I just update the code and used "arc diff update..." etc

Apr 15 2021, 12:03 PM

Apr 14 2021

Hakimb retitled D5501: add an anti-Dos limit for edges traversed as a query parameter from add an anti Ddos limit for edges traversed as a query parameter to add an anti-Dos limit for edges traversed as a query parameter.
Apr 14 2021, 3:58 PM
Hakimb updated the diff for D5501: add an anti-Dos limit for edges traversed as a query parameter.

'max_edges' have now a default value (0 for no limit) which allow to simplify the java code

Apr 14 2021, 3:56 PM
Hakimb added a comment to T2981: Graph API: add a (node type) result filters.

1/ So for the "filter that applies to visits that return nodes one by one" part, we are talking about: neighbors, walk, visit/nodes only?
2/ the filter is a query parameter I guess?

Apr 14 2021, 12:27 PM · Graph service

Apr 13 2021

Hakimb requested review of D5501: add an anti-Dos limit for edges traversed as a query parameter.
Apr 13 2021, 5:38 PM
Hakimb added a revision to T3161: graph service: add anti-DoS limit on the number of edges traversed: D5501: add an anti-Dos limit for edges traversed as a query parameter.
Apr 13 2021, 5:36 PM · Graph service

Apr 8 2021

Hakimb added a comment to T3161: graph service: add anti-DoS limit on the number of edges traversed.

I have two questions to make sure I understand well :

Apr 8 2021, 1:17 PM · Graph service

Apr 6 2021

Hakimb updated the diff for D5411: return a 400 error when accessing endpoints without the arguments.

complete the task on the right server and add tests

Apr 6 2021, 9:30 PM
Hakimb added a comment to D5411: return a 400 error when accessing endpoints without the arguments.

I thought we should group the code by endpoint type, all the "get" endpoints without arguments between them (we can consider them as default cases), as well as the "before" endpoints and the "get" endpoints with detailed arguments that were already coded. I may be wrong

Apr 6 2021, 11:38 AM
Hakimb retitled D5411: return a 400 error when accessing endpoints without the arguments from Related to T1968 : accessing an endpoint without argument returns an error 400 to return a 400 error when accessing endpoints without the arguments.
Apr 6 2021, 11:31 AM
Hakimb added a revision to T1968: existing graph endpoints should not return 404 upon missing arguments: D5411: return a 400 error when accessing endpoints without the arguments.
Apr 6 2021, 11:31 AM · Easy hack, Graph service

Apr 2 2021

Hakimb requested review of D5411: return a 400 error when accessing endpoints without the arguments.
Apr 2 2021, 5:26 PM