Page MenuHomeSoftware Heritage

faux (mihir karbelkar)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 21 2019, 4:00 PM (4 w, 6 d)

Recent Activity

Tue, Apr 16

faux updated the diff for D1420: Made changes to adapt it to new content_find return type.

Made the required changes

Tue, Apr 16, 4:37 PM
Herald added a reviewer for D1420: Made changes to adapt it to new content_find return type: Reviewers.
Tue, Apr 16, 2:27 PM
faux added a revision to T1349: Storage.content_find should return all matches, not just one.: D1420: Made changes to adapt it to new content_find return type.
Tue, Apr 16, 2:27 PM · Easy hack, Storage manager
faux updated the diff for D1288: Storage.content_find returns list instead of single value.

Missed a function in in_memory

Tue, Apr 16, 2:19 PM

Sun, Apr 14

faux added a comment to T808: phabricator lister.

Sure go ahead ;)

Sun, Apr 14, 2:13 PM · Easy hack, Phabricator forge
faux added a comment to T808: phabricator lister.

Hey, if @nahimilega is still working on this? If not then can I poke into this as it would be a good practice for me before implementing launchpad lister and gogs lister. Thanks :)

Sun, Apr 14, 7:01 AM · Easy hack, Phabricator forge

Sat, Apr 13

faux updated the diff for D1288: Storage.content_find returns list instead of single value.

Made the required changes

Sat, Apr 13, 11:22 AM
faux added a comment to D1288: Storage.content_find returns list instead of single value.

Sorry pushed the wrong thing...

Sat, Apr 13, 11:18 AM
faux updated the diff for D1288: Storage.content_find returns list instead of single value.

Merged the for loop removed assertEqual for length and content find return empty list

Sat, Apr 13, 11:14 AM
faux updated the diff for D1288: Storage.content_find returns list instead of single value.

Added the tests for colliding sha256 and blake2s256 hashes

Sat, Apr 13, 9:25 AM

Fri, Apr 12

faux updated the diff for D1288: Storage.content_find returns list instead of single value.

Added more tests for content_find.

Fri, Apr 12, 4:37 PM
faux updated the diff for D1288: Storage.content_find returns list instead of single value.

Removed the if(s), for loop, LIMIT ALL. Made the query a bit more readable.

Fri, Apr 12, 5:47 AM

Thu, Apr 11

faux added a comment to D1288: Storage.content_find returns list instead of single value.

Almost there. Just stuck on the query part.

Thu, Apr 11, 3:38 PM

Wed, Apr 10

faux updated the diff for D1288: Storage.content_find returns list instead of single value.

Have made the requested changes
In db.py : I have changed the content_find method to make the sql query on python side
In test_storage.py : Have added test for duplicate content

Wed, Apr 10, 11:35 PM

Tue, Apr 2

faux added a comment to D1288: Storage.content_find returns list instead of single value.

fwiw, from irc discussion:

20:07 <faux__> pinkieval: I have made all the required changes but I am still confused about the test as in what should we do when the content is duplicated? Sorry to be a bit late as I was travelling so rarely had internet connectivity
20:15 <+pinkieval> faux__: The content is not duplicated in the existing tests. You must add a new test where the content is duplicated, to see how content_find behaves
20:17 <faux__> By using content_add right? I did that but apparently content_find only finds one result and not two of the same result in the list
20:31 <+pinkieval> the goal of your change is to make content_find find more than one
10:17 <+ardumont> because content_add filters on existing contents so if you inject the same content twice, you will have only 1 content in the db

I also found out the same thing when I was adding duplicate content to database using content_add........ so if it will automatically filter duplicate data then content_find should return only one data as a list, right?.....

Tue, Apr 2, 5:30 AM

Wed, Mar 27

faux added a comment to D1288: Storage.content_find returns list instead of single value.

Thanks, will get back to you with required changes.

Wed, Mar 27, 4:53 PM

Mar 24 2019

faux updated the summary of D1288: Storage.content_find returns list instead of single value.
Mar 24 2019, 6:12 PM
faux added a revision to T1349: Storage.content_find should return all matches, not just one.: D1288: Storage.content_find returns list instead of single value.
Mar 24 2019, 6:10 PM · Easy hack, Storage manager
Herald added 1 required legal document(s) to D1288: Storage.content_find returns list instead of single value: L3 Software Heritage Contributor License Agreement, version 1.0.
Mar 24 2019, 6:10 PM