Page MenuHomeSoftware Heritage
Create Task
Maniphest T2494

tests: Use data model objects within tests (drop dicts)
Closed, MigratedEdits Locked
Actions

Description

Migrate data tests to use model objects.
That will exerce more our model objects which we started migrated slowly everywhere.

Main pain points right now is the storage which this task will focus on first.

The goal to reach is at the end of this task, we can drop the validate proxy which is no longer used in production but solely in tests.
And that makes reasoning and maintenance harder than necessary.

Revisions and Commits

rDLDG Git loader
D3544rDLDG3bca9bb3210e tests: Check against snapshot model object
rDLDHG Mercurial loader
D3547rDLDHG6a3c89a93877 tests: Check against snapshot model object
rDLDBASE Generic VCS/Package Loader
D3543rDLDBASE5acfe7479a48 check_snapshot: Drop accepting using dict for snapshot comparison
D3542rDLDBASE01f273d5d87b test_pypi: Check against snapshot model object
D3541rDLDBASE56b024b8fc3b test_npm: Check against snapshot model object
D3539rDLDBASE7c2b3668052a test_nixguix: Check against snapshot model object
D3538rDLDBASEcede65ed1f3c test_deposit: Check against snapshot model object
D3537rDLDBASEa0a131142843 test_cran: Check against snapshot model object
D3536rDLDBASE767971963d7b test_debian: Check against snapshot model object
D3533rDLDBASEd4cce1aedda2 test_archive: Check against snapshot model object
rDSTO Storage manager
D3593rDSTOccbd2e9c21e6 pytest_plugin: Make sample_data an object
D3592rDSTO67a909e0fb69 pytest_plugin: Rename sample_data_model to sample_data
D3591rDSTOe005900bd7ed pytest_plugin: Drop sample_data in favor of sample_data_model
D3590rDSTObbe840e089d1 storage_data: Expose snapshots as model objects
D3589rDSTOd0cf317e7c87 storage_data: Expose release as model objects
D3588rDSTO3be5327f0a0e storage_data: Expose origin_visits as model objects
D3587rDSTObcc0aee8d9cb storage_data: Expose origins as model objects
D3586rDSTOd4cd33c3aab4 storage_data: Expose revisions as model objects
D3585rDSTO955b6e28533c storage_data: Expose directories as directory model objects
D3584rDSTO95dbdf792ea2 storage_data: Remove unused fixture data
D3583rDSTO98a87fec5fce storage_data: Expose contents as content model object
D3582rDSTOa23b748995a0 pytest_plugin: Drop unnecessary back and forth conversion
D3580rDSTO96b2636703c9 tests: Convert left-over dicts to model objects
D3578rDSTO42ae56d98546 test_storage: Migrate last storage to use model objects
D3577rDSTOd4f896e00225 test_storage: test_origin: Use data model object
D3576rDSTO6bdfd85c9208 test_storage: origin_metadata: Centralize objects within sample_data_model
D3575rDSTOa6f70c368031 test_storage: content_metadata: Centralize objects within sample_data_model
D3574rDSTOc9e921eb45d5 test_storage: test_object_find_by_sha1: Use data model object
D3573rDSTOcaa7f7947992 test_storage: content_find: Use data model object
D3572rDSTO64535049b02d test_storage: stat_counters: Use data model object
D3571rDSTOcf80d3c29d7a test_storage: snapshot: Use data model object
D3570rDSTO4f1017173b98 test_storage: origin_visit/origin_visit_status: Use data model object
D3569rDSTO1c1bef91e1b6 test_storage: revision/release: Drop no longer needed conditionals
D3568rDSTOcdf6f580817c test_storage: origin: Use data model object
D3567rDSTObbdd7ed48db9 tests: Drop deprecated storage.origin_add_one use
D3565rDSTO4971c25b7728 test_storage: release: Use data model object
D3564rDSTOa17c4128d809 test_storage: revision: Use data model object
D3563rDSTO87b1070b8f39 test_storage: directory: Use data model object
D3559rDSTO1a2b85fa1eeb test_storage: Make swh_contents fixture generate content model objects
D3558rDSTO99a28ad30b14 tests.generate_data_test: Remove dead code
D3557rDSTO03e17c3600f3 test_storage: skipped_content/content_missing: Use data model object
D3556rDSTO997ec1dbf77e test.storage: content_add_metadata: Use data model object
D3555rDSTO8c2d6358a567 test.storage: content_add: Use data model object
D3554rDSTO2b239f02f69c test_cassandra: Use data model object
D3535rDSTO04d25df5a2ee test_cli: Use snapshot model object within test
D3530rDSTO2d4f727139c0 algos.test_origin: Use data model object and drop validate proxy use
D3529rDSTO97a07211e87c algos.test_snapshot: Use model objects from sample_data_model
D3523rDSTOa688e822a81f test_revision_bw_compat: Use revision model object
D3513rDSTO21efe2a09ea6 test_filter: Use model objects in tests and drop validate proxy
D3512rDSTO2ff4c6fcd5e7 test_buffer: Use model objects in tests and drop validate proxy
D3511rDSTOdf45641008cd test_retry: Drop validate proxy when we can
D3510rDSTO14b164888928 test_retry: Use sample_data_model fixture to manipulate model objects
D3509rDSTOdf3f46decce3 pytest-plugin: Expose a sample_data_model fixture
rDLDSVN Subversion (SVN) loader
D3546rDLDSVNcafefb7946a0 tests: Check against snapshot model object

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ardumont added a commit: rDLDBASEd4cce1aedda2: test_archive: Check against snapshot model object.Jul 16 2020, 6:11 PM
ardumont added a commit: rDLDBASE767971963d7b: test_debian: Check against snapshot model object.
ardumont added a commit: rDLDBASEa0a131142843: test_cran: Check against snapshot model object.
ardumont added a commit: rDLDBASEcede65ed1f3c: test_deposit: Check against snapshot model object.Jul 16 2020, 6:16 PM
ardumont added a revision: D3539: test_nixguix: Check against snapshot model object.Jul 16 2020, 6:23 PM
ardumont added a revision: D3541: test_npm: Check against snapshot model object.Jul 16 2020, 6:40 PM
ardumont added a revision: D3542: test_pypi: Check against snapshot model object.Jul 16 2020, 6:58 PM
ardumont added a revision: D3543: check_snapshot: Drop accepting using dict for snapshot comparison.Jul 16 2020, 7:05 PM
ardumont added a revision: D3544: tests: Check against snapshot model object.Jul 17 2020, 10:33 AM
ardumont added a revision: D3546: tests: Check against snapshot model object.Jul 17 2020, 11:01 AM
ardumont added a revision: D3547: tests: Check against snapshot model object.Jul 17 2020, 11:14 AM
ardumont added a commit: rDLDBASE7c2b3668052a: test_nixguix: Check against snapshot model object.Jul 17 2020, 11:21 AM
ardumont added a commit: rDLDBASE56b024b8fc3b: test_npm: Check against snapshot model object.
ardumont added a commit: rDLDBASE01f273d5d87b: test_pypi: Check against snapshot model object.
ardumont added a commit: rDLDSVNcafefb7946a0: tests: Check against snapshot model object.Jul 17 2020, 11:24 AM
ardumont added a commit: rDLDHG6a3c89a93877: tests: Check against snapshot model object.
ardumont added a commit: rDLDG3bca9bb3210e: tests: Check against snapshot model object.
ardumont added a commit: rDLDBASE5acfe7479a48: check_snapshot: Drop accepting using dict for snapshot comparison.Jul 17 2020, 11:27 AM
ardumont added a revision: D3554: test_cassandra: Use data model object.Jul 17 2020, 4:38 PM
ardumont added a revision: D3555: test.storage: content_add: Use data model object.Jul 17 2020, 5:00 PM
ardumont added a revision: D3556: test.storage: content_add_metadata: Use data model object.Jul 17 2020, 5:52 PM
ardumont added a commit: rDSTO2b239f02f69c: test_cassandra: Use data model object.Jul 17 2020, 5:53 PM
ardumont added a commit: rDSTO8c2d6358a567: test.storage: content_add: Use data model object.Jul 20 2020, 9:48 AM
ardumont added a commit: rDSTO997ec1dbf77e: test.storage: content_add_metadata: Use data model object.
ardumont added a revision: D3557: test_storage: skipped_content/content_missing: Use data model object.Jul 20 2020, 10:15 AM
ardumont added a revision: D3558: tests.generate_data_test: Remove dead code.Jul 20 2020, 10:42 AM
ardumont added a revision: D3559: test_storage: Make swh_contents fixture generate content model objects.Jul 20 2020, 11:10 AM
ardumont added a revision: D3563: test_storage: directory: Use data model object.Jul 20 2020, 11:59 AM
ardumont added a commit: rDSTO03e17c3600f3: test_storage: skipped_content/content_missing: Use data model object.Jul 20 2020, 12:02 PM
ardumont added a commit: rDSTO99a28ad30b14: tests.generate_data_test: Remove dead code.
ardumont added a commit: rDSTO1a2b85fa1eeb: test_storage: Make swh_contents fixture generate content model objects.Jul 20 2020, 12:17 PM
ardumont added a commit: rDSTO87b1070b8f39: test_storage: directory: Use data model object.
ardumont added a revision: D3564: test_storage: revision: Use data model object.Jul 20 2020, 12:55 PM
ardumont added a revision: D3565: test_storage: release: Use data model object.Jul 20 2020, 1:20 PM
ardumont added a commit: rDSTOa17c4128d809: test_storage: revision: Use data model object.Jul 20 2020, 1:38 PM
ardumont added a revision: D3567: tests: Drop deprecated storage.origin_add_one use.Jul 20 2020, 1:48 PM
ardumont added a commit: rDSTO4971c25b7728: test_storage: release: Use data model object.Jul 20 2020, 2:10 PM
ardumont added a commit: rDSTObbdd7ed48db9: tests: Drop deprecated storage.origin_add_one use.
ardumont added a revision: D3568: test_storage: origin: Use data model object.Jul 20 2020, 2:33 PM
ardumont added a revision: D3569: test_storage: revision/release: Drop no longer needed conditionals.Jul 20 2020, 2:52 PM
ardumont added a commit: rDSTOcdf6f580817c: test_storage: origin: Use data model object.Jul 20 2020, 3:16 PM
ardumont added a commit: rDSTO1c1bef91e1b6: test_storage: revision/release: Drop no longer needed conditionals.
ardumont added a revision: D3570: test_storage: origin_visit/origin_visit_status: Use data model object.Jul 20 2020, 3:35 PM
ardumont added a revision: D3571: test_storage: snapshot: Use data model object.Jul 20 2020, 3:58 PM
ardumont added a revision: D3572: test_storage: stat_counters: Use data model object.Jul 20 2020, 4:35 PM
ardumont added a revision: D3573: test_storage: content_find: Use data model object.Jul 20 2020, 5:46 PM
ardumont added a revision: D3574: test_storage: test_object_find_by_sha1: Use data model object.Jul 20 2020, 5:58 PM
ardumont added a commit: rDSTO4f1017173b98: test_storage: origin_visit/origin_visit_status: Use data model object.Jul 20 2020, 6:16 PM
ardumont added a commit: rDSTOcf80d3c29d7a: test_storage: snapshot: Use data model object.
ardumont added a commit: rDSTO64535049b02d: test_storage: stat_counters: Use data model object.
ardumont added a commit: rDSTOcaa7f7947992: test_storage: content_find: Use data model object.
ardumont added a commit: rDSTOc9e921eb45d5: test_storage: test_object_find_by_sha1: Use data model object.
ardumont added a revision: D3575: test_storage: content_metadata: Centralize objects within sample_data_model.Jul 20 2020, 10:23 PM
ardumont added a revision: D3576: test_storage: origin_metadata: Centralize objects within sample_data_model.
ardumont added a revision: D3577: test_storage: test_origin: Use data model object.
ardumont added a revision: D3578: test_storage: Migrate last storage to use model objects.
ardumont added a commit: rDSTOa6f70c368031: test_storage: content_metadata: Centralize objects within sample_data_model.Jul 21 2020, 9:36 AM
ardumont added a commit: rDSTO6bdfd85c9208: test_storage: origin_metadata: Centralize objects within sample_data_model.
ardumont added a commit: rDSTOd4f896e00225: test_storage: test_origin: Use data model object.
ardumont added a commit: rDSTO42ae56d98546: test_storage: Migrate last storage to use model objects.
ardumont updated the task description. (Show Details)Jul 21 2020, 9:43 AM
ardumont added a revision: D3580: tests: Convert left-over dicts to model objects.Jul 21 2020, 10:20 AM
ardumont added a revision: D3581: cli.task: Fix iter_origin returned types.Jul 21 2020, 10:35 AM
ardumont removed a revision: D3581: cli.task: Fix iter_origin returned types.Jul 21 2020, 10:45 AM
ardumont renamed this task from tests: Prefer data model objects to dict within tests to tests: Use data model objects within tests (drop dicts).Jul 21 2020, 10:51 AM
ardumont added a commit: rDSTO96b2636703c9: tests: Convert left-over dicts to model objects.Jul 21 2020, 11:18 AM
ardumont mentioned this in rDSCH9f52d956831a: cli.task: Fix iter_origin returned types.Jul 21 2020, 11:34 AM
ardumont added a revision: D3582: pytest_plugin: Drop unnecessary back and forth conversion.Jul 21 2020, 2:50 PM
ardumont added a revision: D3583: storage_data: Expose contents as content model object.Jul 21 2020, 2:59 PM
ardumont added a revision: D3584: storage_data: Remove unused fixture data.Jul 21 2020, 3:09 PM
ardumont added a revision: D3585: storage_data: Expose directories as directory model objects.Jul 21 2020, 3:35 PM
ardumont added a revision: D3586: storage_data: Expose revisions as model objects.Jul 21 2020, 4:30 PM
ardumont added a revision: D3587: storage_data: Expose origins as model objects.Jul 21 2020, 4:51 PM
ardumont added a revision: D3588: storage_data: Expose origin_visits as model objects.Jul 21 2020, 5:21 PM
ardumont added a revision: D3589: storage_data: Expose releases as model objects.Jul 21 2020, 5:32 PM
ardumont added a revision: D3590: storage_data: Expose snapshots as model objects.Jul 21 2020, 5:42 PM
ardumont added a revision: D3591: pytest_plugin: Drop sample_data to in favor of sample_data_model.Jul 21 2020, 6:09 PM
ardumont added a revision: D3592: pytest_plugin: Rename sample_data_model to sample_data.Jul 21 2020, 6:15 PM
ardumont added a revision: D3593: pytest_plugin: Make sample_data an object with attributes instead of dict.Jul 22 2020, 8:57 AM
ardumont added a commit: rDSTOa23b748995a0: pytest_plugin: Drop unnecessary back and forth conversion.Jul 22 2020, 10:57 AM
ardumont added a commit: rDSTO98a87fec5fce: storage_data: Expose contents as content model object.Jul 22 2020, 11:00 AM
ardumont added a commit: rDSTO95dbdf792ea2: storage_data: Remove unused fixture data.Jul 22 2020, 11:03 AM
ardumont added a commit: rDSTO955b6e28533c: storage_data: Expose directories as directory model objects.
ardumont added a commit: rDSTOd4cd33c3aab4: storage_data: Expose revisions as model objects.
ardumont added a commit: rDSTObcc0aee8d9cb: storage_data: Expose origins as model objects.
ardumont added a commit: rDSTO3be5327f0a0e: storage_data: Expose origin_visits as model objects.
ardumont added a commit: rDSTOd0cf317e7c87: storage_data: Expose release as model objects.
ardumont added a commit: rDSTObbe840e089d1: storage_data: Expose snapshots as model objects.
ardumont closed subtask T2499: Drop the storage validate proxy used only in tests as Resolved.Jul 22 2020, 12:32 PM
ardumont added a commit: rDSTOe005900bd7ed: pytest_plugin: Drop sample_data in favor of sample_data_model.Jul 22 2020, 4:57 PM
ardumont added a commit: rDSTO67a909e0fb69: pytest_plugin: Rename sample_data_model to sample_data.
ardumont added a commit: rDSTOccbd2e9c21e6: pytest_plugin: Make sample_data an object.
ardumont closed this task as Resolved.Jul 22 2020, 4:59 PM
ardumont claimed this task.
ardumont added a parent task: T645: Type swh-storage endpoints with swh.model objects.Jul 23 2020, 10:15 AM
gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 4:31 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

gitlab-migration changed the status of subtask T2499: Drop the storage validate proxy used only in tests from Resolved to Migrated.Jan 8 2023, 4:31 PM
About · Developer information · Legal