Differential D3558

tests.generate_data_test: Remove dead code
ClosedPublic
Actions

Authored by ardumont on Jul 20 2020, 10:42 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTO99a28ad30b14: tests.generate_data_test: Remove dead code

Summary

The storage fixtures now uses the swh.model.tests.generate_data_test instead

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 20 2020, 10:42 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 20 2020, 10:42 AM

Build is green

Patch application report for D3558 (id=12539)

Could not rebase; Attempt merge onto 997ec1dbf7...

Updating 997ec1db..0e21f539
Fast-forward
 swh/storage/tests/generate_data_test.py |  49 -------------
 swh/storage/tests/storage_data.py       |   2 +-
 swh/storage/tests/test_storage.py       | 118 +++++++++++++-------------------
 3 files changed, 50 insertions(+), 119 deletions(-)
 delete mode 100644 swh/storage/tests/generate_data_test.py

Changes applied before test

commit 0e21f539369f6b5a949c077fd0c9dfb2b7520eff
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 10:41:02 2020 +0200

    tests.generate_data_test: Remove dead code
    
    The storage fixtures now uses the swh.model.tests.generate_data_test instead
    
    Related to T2494

commit 0a5b5d82ede3e67fc6862c8e07924d4e98a6c162
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 10:12:13 2020 +0200

    test_storage: skipped_content/content_missing: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/481/ for more details.

Harbormaster completed remote builds in B13762: Diff 12539.Jul 20 2020, 10:48 AM

vlorentz accepted this revision.Jul 20 2020, 10:53 AM

This revision is now accepted and ready to land.Jul 20 2020, 10:53 AM

Rebase

Build is green

Patch application report for D3558 (id=12544)

Could not rebase; Attempt merge onto 7131dcb9cf...

Updating 7131dcb9..99a28ad3
Fast-forward
 swh/storage/tests/generate_data_test.py |  49 -------------
 swh/storage/tests/storage_data.py       |   2 +-
 swh/storage/tests/test_storage.py       | 118 +++++++++++++-------------------
 3 files changed, 50 insertions(+), 119 deletions(-)
 delete mode 100644 swh/storage/tests/generate_data_test.py

Changes applied before test

commit 99a28ad30b14ec72b8458ecd9503b22b7898e323
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 10:41:02 2020 +0200

    tests.generate_data_test: Remove dead code
    
    The storage fixtures now uses the swh.model.tests.generate_data_test instead
    
    Related to T2494

commit 03e17c3600f340e077d835f19cba05893d114612
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 10:12:13 2020 +0200

    test_storage: skipped_content/content_missing: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/484/ for more details.

Harbormaster completed remote builds in B13767: Diff 12544.Jul 20 2020, 11:15 AM

Closed by commit rDSTO99a28ad30b14: tests.generate_data_test: Remove dead code (authored by ardumont). · Explain WhyJul 20 2020, 12:02 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO99a28ad30b14: tests.generate_data_test: Remove dead code.