Differential D3580

tests: Convert left-over dicts to model objects
ClosedPublic
Actions

Authored by ardumont on Jul 21 2020, 10:20 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTO96b2636703c9: tests: Convert left-over dicts to model objects

Summary

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 21 2020, 10:20 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 21 2020, 10:20 AM

ardumont mentioned this in D3579: Drop no longer used validate proxy.Jul 21 2020, 10:21 AM

Add missing dicts (messed up my git manipulations ;)

Build has FAILED

Patch application report for D3580 (id=12596)

Rebasing onto 42ae56d985...

Current branch diff-target is up to date.

Changes applied before test

commit 21cb1b90470eb3898ca08263be04735629276c76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jul 21 10:12:37 2020 +0200

    tests: Convert left-over dicts to model objects
    
    Related to T2494

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/513/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/513/console

Harbormaster failed remote builds in B13821: Diff 12596!Jul 21 2020, 10:28 AM

...

build has failed

yeah... i know, fixing

Build has FAILED

Patch application report for D3580 (id=12598)

Rebasing onto 42ae56d985...

Current branch diff-target is up to date.

Changes applied before test

commit 5e8e1fc89e64a773857ae8df4ad0ab60e1e67676
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jul 21 10:12:37 2020 +0200

    tests: Convert left-over dicts to model objects
    
    Related to T2494

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/515/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/515/console

Harbormaster failed remote builds in B13823: Diff 12598!Jul 21 2020, 10:42 AM

Fix swh_storage to swh_storage_validate (wrong git amend again)
This should fix the build

Build is green

Patch application report for D3580 (id=12600)

Rebasing onto 42ae56d985...

Current branch diff-target is up to date.

Changes applied before test

commit 96b2636703c9a0c8e272c8403f193baffe07d7e5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jul 21 10:12:37 2020 +0200

    tests: Convert left-over dicts to model objects
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/516/ for more details.

Harbormaster completed remote builds in B13825: Diff 12600.Jul 21 2020, 10:51 AM

vlorentz accepted this revision.Jul 21 2020, 11:11 AM

This revision is now accepted and ready to land.Jul 21 2020, 11:11 AM

Closed by commit rDSTO96b2636703c9: tests: Convert left-over dicts to model objects (authored by ardumont). · Explain WhyJul 21 2020, 11:18 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO96b2636703c9: tests: Convert left-over dicts to model objects.