Related to T2494
Details
Details
- Reviewers
douardda - Group Reviewers
Reviewers - Maniphest Tasks
- T2494: tests: Use data model objects within tests (drop dicts)
- Commits
- rDLDSVNcafefb7946a0: tests: Check against snapshot model object
tox
Diff Detail
Diff Detail
- Repository
- rDLDSVN Subversion (SVN) loader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D3546 (id=12499)
Could not rebase; Attempt merge onto 9d16dc0f22...
Updating 9d16dc0..191b4ef Fast-forward swh/loader/svn/loader.py | 19 +-- swh/loader/svn/tests/test_loader.py | 280 ++++++++++++++++-------------------- 2 files changed, 130 insertions(+), 169 deletions(-)
Changes applied before test
commit 191b4eff36dc18158c805956491c4622158a6f76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Jul 17 10:50:55 2020 +0200
tests: Check against snapshot model object
Related to T2494
commit c9473c563456352e2723d9f284e19ef0c4d16e4a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Jul 17 10:41:23 2020 +0200
svn.loader: Drop unneeded indirectionSee https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/80/ for more details.
Comment Actions
Build is green
Patch application report for D3546 (id=12502)
Could not rebase; Attempt merge onto 9d16dc0f22...
Updating 9d16dc0..cafefb7 Fast-forward swh/loader/svn/loader.py | 19 +-- swh/loader/svn/tests/test_loader.py | 280 ++++++++++++++++-------------------- 2 files changed, 130 insertions(+), 169 deletions(-)
Changes applied before test
commit cafefb7946a02302c828ba7ee0632186cb73d2d1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Jul 17 10:50:55 2020 +0200
tests: Check against snapshot model object
Related to T2494
commit db932e4a4dd9073f44078fb8dd9884714329fc53
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Jul 17 10:41:23 2020 +0200
svn.loader: Drop `build_swh_snapshot` function, oneliner used once
Coverage remained the same as this part is already tested by other scenario.See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/82/ for more details.