Differential D3544

tests: Check against snapshot model object
ClosedPublic
Actions

Authored by ardumont on Jul 17 2020, 10:33 AM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDLDG3bca9bb3210e: tests: Check against snapshot model object

Summary

Note: this adds one missing check-snapshot call.

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 17 2020, 10:33 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 17 2020, 10:33 AM

ardumont mentioned this in D3543: check_snapshot: Drop accepting using dict for snapshot comparison.Jul 17 2020, 10:34 AM

Build is green

Patch application report for D3544 (id=12496)

Rebasing onto a6dd6356e4...

Current branch diff-target is up to date.

Changes applied before test

commit 3bca9bb3210ed2a9278d89d6614669b5c9028cd8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 17 10:33:36 2020 +0200

    tests: Check against snapshot model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/44/ for more details.

Harbormaster completed remote builds in B13720: Diff 12496.Jul 17 2020, 10:35 AM

douardda accepted this revision.Jul 17 2020, 11:10 AM

This revision is now accepted and ready to land.Jul 17 2020, 11:10 AM

Closed by commit rDLDG3bca9bb3210e: tests: Check against snapshot model object (authored by ardumont). · Explain WhyJul 17 2020, 11:25 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDG3bca9bb3210e: tests: Check against snapshot model object.

Revision Contents
Changeset List

Path

Size

swh/

loader/

git/

tests/

test_from_disk.py

63 lines

Diff 12510

View Options

swh/loader/git/tests/test_from_disk.py

tests: Check against snapshot model objectClosedPublicActions