test_cli: Use snapshot model object within test
ClosedPublic
Actions

Authored by ardumont on Jul 16 2020, 5:32 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTO04d25df5a2ee: test_cli: Use snapshot model object within test

Summary

That commit is not so interesting. But at least we validate the snapshot is
correct prior to sending it.

Also that removes a bit duplicated storage configuration.

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 16 2020, 5:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 16 2020, 5:32 PM

Build is green

Patch application report for D3535 (id=12478)

Rebasing onto 2d4f727139...

Current branch diff-target is up to date.

Changes applied before test

commit cd3680dcba5bd5565e30f24c20dab68b8850a320
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 17:31:28 2020 +0200

    test_cli: Use snapshot model object within test
    
    That commit is not so interesting. But at least we validate the snapshot is
    correct prior to sending it.
    
    Also that removesa bit duplicated storage configuration.
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/471/ for more details.

Harbormaster completed remote builds in B13702: Diff 12478.Jul 16 2020, 5:37 PM

anlambert accepted this revision.Jul 16 2020, 5:49 PM

anlambert added a subscriber: anlambert.

anlambert added inline comments.

swh/storage/tests/test_cli.py
78	you can remove that line, real id will be computed when creating the `Snapshot` object

This revision is now accepted and ready to land.Jul 16 2020, 5:49 PM

ardumont edited the summary of this revision. (Show Details)Jul 16 2020, 5:51 PM

Adapt according to review (drop the foo id as this will get computed itself by the model object \m/)
Fix typo in commit message

swh/storage/tests/test_cli.py
78	thx!

Build is green

Patch application report for D3535 (id=12482)

Rebasing onto 2d4f727139...

Current branch diff-target is up to date.

Changes applied before test

commit 04d25df5a2ee63ad4cccd7656e047d46b75b1eef
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 17:31:28 2020 +0200

    test_cli: Use snapshot model object within test
    
    That commit is not so interesting. But at least we validate the snapshot is
    correct prior to sending it.
    
    Also that removes a bit duplicated storage configuration.
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/472/ for more details.

Harbormaster completed remote builds in B13706: Diff 12482.Jul 16 2020, 5:58 PM

Closed by commit rDSTO04d25df5a2ee: test_cli: Use snapshot model object within test (authored by ardumont). · Explain WhyJul 16 2020, 6:07 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO04d25df5a2ee: test_cli: Use snapshot model object within test.