Differential D3555

test.storage: content_add: Use data model object
ClosedPublic
Actions

Authored by ardumont on Jul 17 2020, 5:00 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTO8c2d6358a567: test.storage: content_add: Use data model object

Summary

It's quite a big test module. So I'll break into small diffs.

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 17 2020, 5:00 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 17 2020, 5:00 PM

Build has FAILED

Patch application report for D3555 (id=12530)

Could not rebase; Attempt merge onto eb2bf8ce68...

Updating eb2bf8ce..7299ddf6
Fast-forward
 swh/storage/tests/test_cassandra.py | 85 ++++++++++++++++++++++---------------
 swh/storage/tests/test_storage.py   | 57 ++++++++++++-------------
 2 files changed, 77 insertions(+), 65 deletions(-)

Changes applied before test

commit 7299ddf6195db70987b70df69c320d37011939ec
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 17 17:00:29 2020 +0200

    test.storage: content_add: Use data model object
    
    Related to T2494

commit 2b239f02f69c54d067c16054a15976268acbdd12
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 17 16:37:31 2020 +0200

    test_cassandra: Use data model object
    
    Related to T2494

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/475/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/475/console

Harbormaster failed remote builds in B13753: Diff 12530!Jul 17 2020, 5:06 PM

Fix comparison

Build is green

Patch application report for D3555 (id=12531)

Could not rebase; Attempt merge onto eb2bf8ce68...

Updating eb2bf8ce..8c2d6358
Fast-forward
 swh/storage/tests/test_cassandra.py | 85 ++++++++++++++++++++++---------------
 swh/storage/tests/test_storage.py   | 57 ++++++++++++-------------
 2 files changed, 77 insertions(+), 65 deletions(-)

Changes applied before test

commit 8c2d6358a56788761817051633d2fe3c20920687
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 17 17:00:29 2020 +0200

    test.storage: content_add: Use data model object
    
    Related to T2494

commit 2b239f02f69c54d067c16054a15976268acbdd12
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 17 16:37:31 2020 +0200

    test_cassandra: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/476/ for more details.

Harbormaster completed remote builds in B13754: Diff 12531.Jul 17 2020, 5:21 PM

vlorentz accepted this revision.Jul 20 2020, 9:43 AM

This revision is now accepted and ready to land.Jul 20 2020, 9:43 AM

Closed by commit rDSTO8c2d6358a567: test.storage: content_add: Use data model object (authored by ardumont). · Explain WhyJul 20 2020, 9:48 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO8c2d6358a567: test.storage: content_add: Use data model object.