Related to T2494
(This adds some missing assertions on the visit status)
Details
Details
- Reviewers
douardda - Group Reviewers
Reviewers - Maniphest Tasks
- T2494: tests: Use data model objects within tests (drop dicts)
- Commits
- rDLDBASE56b024b8fc3b: test_npm: Check against snapshot model object
tox
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D3541 (id=12492)
Could not rebase; Attempt merge onto cede65ed1f...
Updating cede65e..45163f0 Fast-forward swh/loader/package/nixguix/tests/test_nixguix.py | 224 ++++++++++------------- swh/loader/package/npm/tests/test_npm.py | 153 +++++++++------- 2 files changed, 183 insertions(+), 194 deletions(-)
Changes applied before test
commit 45163f02e1c5a078717acb92ce241e2149d0ce84
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Jul 16 18:40:33 2020 +0200
test_npm: Check against snapshot model object
Related to T2494
commit 4df9a4a09790c690d9888d704c6b66c894180e80
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Jul 16 18:23:32 2020 +0200
test_nixguix: Merge check_snapshot* methods into 1
commit 7c2b3668052a97e7e7b25fa0687b412b2010ebeb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Jul 16 18:22:18 2020 +0200
test_nixguix: Check against snapshot model object
Related to T2494See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/174/ for more details.
Comment Actions
Build is green
Patch application report for D3541 (id=12493)
Could not rebase; Attempt merge onto cede65ed1f...
Updating cede65e..56b024b Fast-forward swh/loader/package/nixguix/tests/test_nixguix.py | 224 ++++++++++------------- swh/loader/package/npm/tests/test_npm.py | 163 ++++++++++------- 2 files changed, 191 insertions(+), 196 deletions(-)
Changes applied before test
commit 56b024b8fc3b93ee1b9d4fce465453ed2e554c7c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Jul 16 18:40:33 2020 +0200
test_npm: Check against snapshot model object
Related to T2494
commit 4df9a4a09790c690d9888d704c6b66c894180e80
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Jul 16 18:23:32 2020 +0200
test_nixguix: Merge check_snapshot* methods into 1
commit 7c2b3668052a97e7e7b25fa0687b412b2010ebeb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Jul 16 18:22:18 2020 +0200
test_nixguix: Check against snapshot model object
Related to T2494See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/175/ for more details.