Differential D3554

test_cassandra: Use data model object
ClosedPublic
Actions

Authored by ardumont on Jul 17 2020, 4:38 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTO2b239f02f69c: test_cassandra: Use data model object

Summary

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 17 2020, 4:38 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 17 2020, 4:38 PM

Build is green

Patch application report for D3554 (id=12529)

Rebasing onto eb2bf8ce68...

Current branch diff-target is up to date.

Changes applied before test

commit 2b239f02f69c54d067c16054a15976268acbdd12
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 17 16:37:31 2020 +0200

    test_cassandra: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/474/ for more details.

Harbormaster completed remote builds in B13752: Diff 12529.Jul 17 2020, 4:43 PM

not sure I like too much the

cont, cont2 = [
          attr.evolve(c, ctime=now()) for c in sample_data_model["content"][:2]
      ]

stuff but oh well.

(I mean I find this easier to read:

cont = attr.evolve(sample_data_model["content"][0], ctime=now())
cont2 = attr.evolve(sample_data_model["content"][1], ctime=now())

)

This revision is now accepted and ready to land.Jul 17 2020, 5:04 PM

That's most probably because i like destructuring a lot (from other languages ;)

If you don't push much more than that though, i'll keep as it is (i'm lazy today ;)

Closed by commit rDSTO2b239f02f69c: test_cassandra: Use data model object (authored by ardumont). · Explain WhyJul 17 2020, 5:53 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO2b239f02f69c: test_cassandra: Use data model object.

Revision Contents
Changeset List

Path

Size

swh/

storage/

tests/

test_cassandra.py

85 lines

Diff 12533

View Options

swh/storage/tests/test_cassandra.py

test_cassandra: Use data model objectClosedPublicActions