Related to T2494
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Maniphest Tasks
- T2494: tests: Use data model objects within tests (drop dicts)
- Commits
- rDSTO2d4f727139c0: algos.test_origin: Use data model object and drop validate proxy use
tox
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D3530 (id=12467)
Could not rebase; Attempt merge onto b6971b5139...
Updating b6971b51..7cdc1c01 Fast-forward swh/storage/algos/origin.py | 4 +-- swh/storage/pytest_plugin.py | 5 +++- swh/storage/tests/algos/test_origin.py | 22 +++++++++------- swh/storage/tests/algos/test_snapshot.py | 44 +++++++++++++++----------------- swh/storage/tests/storage_data.py | 23 +++++++++++++++++ swh/storage/tests/test_pytest_plugin.py | 2 ++ 6 files changed, 65 insertions(+), 35 deletions(-)
Changes applied before test
commit 7cdc1c0167e37665d0b5dafa6ed18d46316d495a Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Thu Jul 16 15:33:36 2020 +0200 algos.test_origin: Use data model object and drop validate proxy use Related to T2494 commit 97a07211e87c5e2cfdbb8594549e5000ea316037 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Thu Jul 16 15:17:33 2020 +0200 algos.test_snapshot: Use model objects from sample_data_model This opens up origin_visits and add new snapshots to the fixture. So we can reuse those. Related to T2494
See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/469/ for more details.
swh/storage/algos/origin.py | ||
---|---|---|
11–17 | While you are modifying this file, can you add typing info to that function ? |
swh/storage/algos/origin.py | ||
---|---|---|
11–17 | ok ;) (it did not even occur to me this time, thanks) |
Comment Actions
Build is green
Patch application report for D3530 (id=12475)
Rebasing onto 97a07211e8...
Current branch diff-target is up to date.
Changes applied before test
commit 2d4f727139c09c28ce470b707150d93256dd9b9b Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Thu Jul 16 15:33:36 2020 +0200 algos.test_origin: Use data model object and drop validate proxy use Related to T2494
See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/470/ for more details.