Page MenuHomeSoftware Heritage

test_storage: content_metadata: Centralize objects within sample_data_model
ClosedPublic

Authored by ardumont on Jul 20 2020, 10:23 PM.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D3575 (id=12587)

Rebasing onto c9e921eb45...

Current branch diff-target is up to date.
Changes applied before test
commit a6f70c368031e0f5d090fd655970447f5b6b7756
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 21:12:55 2020 +0200

    test_storage: content_metadata: Centralize objects within sample_data_model
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/508/ for more details.

vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/storage/pytest_plugin.py
224–240

I don't like this change, it's more verbose and less readable. But that's not a big deal

This revision is now accepted and ready to land.Jul 21 2020, 9:24 AM
swh/storage/pytest_plugin.py
224–240

Well, yeah.
It was for consistency reading for the metadata objects.
(And this allows to add more if we need more along the way, i think in other diffs i add some ;)

And fortunately, this is only temporary and that sample_data will disappear soon ;)