even better ;)

2 remarks inline.

Looks good!

Build is green

Fix unordered function return + rebase

Build has FAILED

• maven-loader: fix tests for unordered function call

Build has FAILED

• loader: add new maven-jar loader
• maven-loader: set the pom as metadata
• maven-loader: fix after final review (ardumont, vlorentz)
• maven-loader: fix metadata for completeness
• maven-loader: fix metadata for pom and json
• maven-loader: move request.get to own function
• maven-loader: fix tests for unordered function call

Build has FAILED

• maven-loader: move request.get to own function

(oops, looks like I sent the review too fast)

You don't need parametrization for test_routing_keys and test_routing_key_error, the code is very short; you can write the assertions directly

You don't need parametrization for test_routing_keys and test_routing_key_error, the code is very short; you can write the assertions directly

In D6692#174129, @olasd wrote:

Could you make sure that this dashboard https://grafana.softwareheritage.org/d/d3l2oqXWz/s3-object-copy?orgId=1 is not affected (or that its functionality can be replaced easily?)

In D6692#174126, @olasd wrote:

You seem to have dropped the CONTENT_BYTES_METRIC ?

Many thanks ;)

Nice catch.

sorry I thought I had accepted it already :-)

@douardda gentle ping?

Build is green

Rebase with latest changes from master

Build has FAILED

• loader: add new maven-jar loader
• maven-loader: set the pom as metadata
• maven-loader: fix after final review (ardumont, vlorentz)
• maven-loader: fix metadata for completeness
• maven-loader: fix metadata for pom and json

Build has FAILED

Build is green

Build is green

Build is green

Build is green

• maven-loader: fix metadata for pom and json

Build is green

rebase

rebase

rebase

rebase

Add docs compilation

Build has FAILED

Updated encode to fix double metadata objects.

Build is green

Rebase.

Build has FAILED

• maven-loader: fix metadata for completeness

Build is green

Build is green

DATE = datetime.fromtimestamp(1000000000)
ONE_SEC = timedelta(seconds=1)
HASH = b"20329687bb9c1231a7e05afe86160343ad49b494"
RESOLVED_DATES = [
    (((HASH, ), (HASH, DATE), (HASH, None)), {HASH: DATE}),
    ((HASH, DATE), (HASH, DATE+ONE_SEC)), {HASH: DATE}),
]
@pytest.mark.parametrize("input,expected", RESOLVED_DATES) 
def test_resolve_dates() -> None:
    assert resolve_dates(input) == expected

I believe we can agree that this is not difficult to follow and read.