Page MenuHomeSoftware Heritage

maven-lister: Add maven lister with review D6133.
Needs ReviewPublic

Authored by borisbaldassari on Sat, Oct 2, 9:21 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Maniphest Tasks
T1724: Maven Central repository Lister
Summary

This is the new revision for the maven-lister, after review D6133.

Diff Detail

Repository
rDLS Listers
Branch
T1724_maven_central_lister
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24397
Build 38081: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 38080: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D6395 (id=23252)

Rebasing onto e7716c0122...

Current branch diff-target is up to date.
Changes applied before test
commit 2af8aae3750e68961e0a12875d30a736d67cb3d6
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sat Oct 2 21:20:08 2021 +0200

    maven-lister: Add maven lister with review D6133.

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/384/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/384/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Oct 2, 9:24 PM
Harbormaster failed remote builds in B24169: Diff 23252!
  • gitlab: Allow listing of instances providing multiple vcs_type
  • gitlab: Allow ingestion of hg_git origins as hg ones
  • Allow gitlab lister's name to be overriden by task arguments
  • opam: Move the state initialization into the get_pages method
  • opam: Make the instance optional and derived from the url
  • opam: Allow defining where to actually install the opam_root folder
  • gnu: Respect the pattern docstring about state initialization
  • opam: Share opam root directory even on multiple instances
  • maven-lister: initialise lister.
  • maven-lister: Refactor file get loop (review D6133).
  • maven-lister: update readme, set tests to use http_index

Build is green

Patch application report for D6395 (id=23481)

Rebasing onto 5bba1a783a...

First, rewinding head to replay your work on top of it...
Applying: gitlab: Allow listing of instances providing multiple vcs_type
Using index info to reconstruct a base tree...
M	swh/lister/gitlab/lister.py
M	swh/lister/gitlab/tests/test_lister.py
Falling back to patching base and 3-way merge...
Auto-merging swh/lister/gitlab/tests/test_lister.py
CONFLICT (content): Merge conflict in swh/lister/gitlab/tests/test_lister.py
Auto-merging swh/lister/gitlab/lister.py
CONFLICT (content): Merge conflict in swh/lister/gitlab/lister.py
Patch failed at 0001 gitlab: Allow listing of instances providing multiple vcs_type

Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".

Rebase failed (ret=1)!

Could not rebase; Attempt merge onto 5bba1a783a...

Already up to date.
Changes applied before test
commit dfe8123508b49ed79490091119aa6a2ebfe05add
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Oct 12 22:56:06 2021 +0200

    maven-lister: update readme, set tests to use http_index

commit a7743ee4bd821da7fae90a046d9a2cbff20c7c32
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sat Oct 2 20:37:56 2021 +0200

    maven-lister: Refactor file get loop (review D6133).

commit 37b103c76722407af068ce54d28365118236c2fb
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Wed Aug 25 14:23:09 2021 +0200

    maven-lister: initialise lister.
    maven-lister: initialise lister.
    maven-lister: add docker in requirements.txt..
    maven-lister: refactor to externalize index export.
    maven-lister: fix test_task with new parameters.
    maven-lister: fix mocking of index download.
    maven-lister: add maven to list_cli for testing.
    maven-lister: fix function doc comment for sphinx.
    maven-lister: add extra loader arguments for jar loader output.
    maven-lister: add extra loader arguments for jar loader output.
    maven-lister: add last modif time to extra args for jar files.
    maven-lister: set last modif time to epoch int.
    maven-lister: add changes from review D6133.
    maven-lister: Fix inaccurate comment (review D6133).
    maven-lister: Fix tests (review D6133)
    maven-lister: Fix various comments from review (review D6133).
    maven-lister: add README.md to describe design decisions (review D6133).
    maven-lister: Fix useless storage of file + minor fixes (review D6133).
    maven-lister: Document regexpes (review D6133).
    maven-lister: various small fixes and optimisations (review D6133).
    maven-lister: various small fixes and optimisations (review D6133).
    maven-lister: Fix and add tests (review D6133).
    maven-lister: Refactor file get loop + minor fixes (review D6133).

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/399/ for more details.