Heh actually that's not an issue, the directory_get_entries documentation does not guarantee an order.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Sep 22 2021
Possible solution: store them as an ascii string instead of an integer.
Possible solution: store a rank along with each directory entry, but ignore it unless we are reconstructing a git object or computing a SWHID (v1?)
Following what i said in the loader diff, i'm actually closing this.
Ack on the lock folder but i won't attend to it immediately.[1] D6318
Build is green
Refactor a bit (drop --strict as suggested)
In T1805#70880, @douardda wrote:
- pagination comes from proper usage of links https://swagger.io/docs/specification/links/
- batches comes from proper usage of parameter serialization https://swagger.io/docs/specification/serialization/
it's true these do not come "for free" but I still have the impression there is an "Open API way" of handling these and we should stick to them.
Build has FAILED
Done and dusted.
rebased patch
Build is green
rebased patch
Following what i said in the loader diff, i'm actually closing this.
Ack on the lock folder but i won't attend to it immediately.
tl; dr Inhibit the cooldown* which default to 7 days.
As it got already scheduled (with whatever results), this is dropped from the grab call.
LGTM (not checked everything is accurate nor there are obvious missing services, but it's a huge improvement as is, thx)
In T1805#45984, @vlorentz wrote:Items 5, 6, 7 aka pagination, auth and batches - I believe these come naturally with item 4 (specification wise)
They don't. OpenAPI is a specification to describe APIs, and it contains absolutely nothing about pagination or batches.
- Remove useless ending '/'
- define VPN / private meanings
Build is green
I think there was already a problem before, but since we have now more chance to hit it, I'd really like the opam_init process to lock the directory when running opam commands.
In D6165#163629, @vlorentz wrote:What is the reason for this change? Is it more efficient assign requests to workers based on ID rather than randomly?
In D6272#163627, @vlorentz wrote:Why the renaming? And it's an RPC API, not REST
It would be nice to have a README fil in swh/lister/maven/tests/data explaining what the data files are, where they come from, how they have been generated, etc.
In D6273#163625, @vlorentz wrote:Why?
In D6165#163629, @vlorentz wrote:What is the reason for this change? Is it more efficient assign requests to workers based on ID rather than randomly?
Build is green
- added stubs
- small fixes
- more doc strings
- Better doc strings
Sep 21 2021
Ok.
What is the motivation for merging directories?
What is the motivation for merging directories?
Sorry, my question was about opam itself. Are you sure it won't corrupt data, or wait on a global lock when accessing that directory?
Sorry, my question was about opam itself. Are you sure it won't corrupt data, or wait on a global lock when accessing that directory?
Same comment as on the other diff: looks like it is for consistency with the new rabbitmq RPC, but please explain it
Looks like it is supposed to be replaced by the rabbitmq-based RPC? Please explain it in the commit/diff message.
Can two listers run in parallel while using the same directory?
What is the reason for this change? Is it more efficient assign requests to workers based on ID rather than randomly?
Why the renaming? And it's an RPC API, not REST
Why?
Can two listers run in parallel while using the same directory?
Build has FAILED
Build is green
rebase
fix test + use email-validator + rebase
Build is green
Build is green
Build is green
Build is green