Page MenuHomeSoftware Heritage

Add a bit of typing
ClosedPublic

Authored by vlorentz on Fri, Sep 17, 4:49 PM.

Diff Detail

Repository
rDLDCVS CVS Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6299 (id=22876)

Could not rebase; Attempt merge onto dd8a625ca0...

Auto-merging swh/loader/cvs/loader.py
Merge made by the 'recursive' strategy.
 .gitignore                          |   1 +
 swh/loader/cvs/loader.py            | 150 ++++++++++++++++++------------------
 swh/loader/cvs/tests/test_loader.py |   3 +
 3 files changed, 81 insertions(+), 73 deletions(-)
Changes applied before test
commit 73e871a4349938cc5787cef17a7e93153e457585
Merge: dd8a625 c9998fd
Author: Jenkins user <jenkins@localhost>
Date:   Fri Sep 17 14:50:04 2021 +0000

    Merge branch 'diff-target' into HEAD

commit c9998fdad5011f575f0fb9edd3d142fcad00d75d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 17 16:49:51 2021 +0200

    Add a bit of typing

commit 4d5e5d25d9f7794e223fac11965343768b53e5fa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 17 16:36:37 2021 +0200

    Simplify exception handling.

commit 051dec1fe0c0252cb569ecf763b49210280cfe7f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 17 16:36:07 2021 +0200

    Ignore generated .so files
    
    They are in this location when installing in development mode.

commit af3755766012b58ddf5713fb2e0504033c9de903
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 17 16:34:37 2021 +0200

    Use lazy substitution for logging + fix error messages
    
    eg. self.log.exception already include the exception (and its traceback),
    so it does not need to be part of the message.

commit b7e97029636648ddb53ad7bed8623e97a546e445
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 17 16:28:52 2021 +0200

    load_status should not be 'uneventful' if the snapshot changed
    
    Even if the revision was already loaded; it might have been for
    a different origin.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/20/ for more details.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Sep 21, 5:58 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D6299 (id=22941)

Rebasing onto a6e9882352...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-26-D6299.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/26/ for more details.