Differential D6317

opam: Initialize opam root directory outside the constructor
ClosedPublic
Actions

Authored by ardumont on Sep 21 2021, 7:36 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T3590: opam loader: Ensure required opam state is shared amongst ingestion/listing runs

Commits

rDLDBASEf4556e0113fa: opam: Initialize opam root directory outside the constructor

Summary

If it's required at all, this will use the network to fetch and install it.
This should be done outside the constructor.

Related to T3590

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 21 2021, 7:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 21 2021, 7:36 PM

Build is green

Patch application report for D6317 (id=22951)

Rebasing onto fabd950d36...

Current branch diff-target is up to date.

Changes applied before test

commit f4556e0113fae658555b0c6f7296ac98c310c971
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 21 19:15:31 2021 +0200

    opam: Initialize opam root directory outside the constructor
    
    If it's required at all, this will use the network to fetch and install it.
    This should be done outside the constructor.
    
    Related to T3590

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/560/ for more details.

Harbormaster completed remote builds in B23882: Diff 22951.Sep 21 2021, 7:38 PM

ardumont requested review of this revision.Sep 21 2021, 7:38 PM

douardda accepted this revision.Sep 22 2021, 10:38 AM

This revision is now accepted and ready to land.Sep 22 2021, 10:38 AM

Closed by commit rDLDBASEf4556e0113fa: opam: Initialize opam root directory outside the constructor (authored by ardumont). · Explain WhySep 22 2021, 12:18 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEf4556e0113fa: opam: Initialize opam root directory outside the constructor.