Page MenuHomeSoftware Heritage

eliminate code duplication of logic in process_cvs_changesets()
ClosedPublic

Authored by stsp on Fri, Sep 17, 4:43 PM.

Details

Summary

Factor out code which is specific to rcsparse and cvsclient into
separate functions and pass a parameter to process_cvs_changesets()
so it can decide which of the two needs to be used.

This supersedes the function process_cvs_rlog_changesets() which
duplicated the looping code also contained in process_cvs_changesets().

Diff Detail

Repository
rDLDCVS CVS Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6298 (id=22875)

Rebasing onto dd8a625ca0...

Current branch diff-target is up to date.
Changes applied before test
commit b982fa244c2da87a0b1140be48a0f932cb494af1
Author: Stefan Sperling <stsp@stsp.name>
Date:   Fri Sep 17 16:39:58 2021 +0200

    eliminate code duplication of logic in process_cvs_changesets()
    
    Factor out code which is specific to rcsparse and cvsclient into
    separate functions and pass a parameter to process_cvs_changesets()
    so it can decide which of the two needs to be used.
    
    This supersedes the function process_cvs_rlog_changesets() which
    duplicated the looping code also contained in process_cvs_changesets().

Link to build: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/19/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/19/console

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Sep 17, 4:44 PM
Harbormaster failed remote builds in B23804: Diff 22875!

apply reformatting by black

Build is green

Patch application report for D6298 (id=22888)

Rebasing onto dd8a625ca0...

Current branch diff-target is up to date.
Changes applied before test
commit 6ff2c133f98183c443d0fa774cb83a539229094c
Author: Stefan Sperling <stsp@stsp.name>
Date:   Fri Sep 17 16:39:58 2021 +0200

    eliminate code duplication of logic in process_cvs_changesets()
    
    Factor out code which is specific to rcsparse and cvsclient into
    separate functions and pass a parameter to process_cvs_changesets()
    so it can decide which of the two needs to be used.
    
    This supersedes the function process_cvs_rlog_changesets() which
    duplicated the looping code also contained in process_cvs_changesets().

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/21/ for more details.

stsp requested review of this revision.Fri, Sep 17, 6:19 PM
This revision is now accepted and ready to land.Fri, Sep 17, 6:20 PM

Build is green

Patch application report for D6298 (id=22956)

Rebasing onto a6e9882352...

Current branch diff-target is up to date.
Changes applied before test
commit a7eaeb89f46f7e027e60d2f0acdcb7453f1a2431
Author: Stefan Sperling <stsp@stsp.name>
Date:   Fri Sep 17 16:39:58 2021 +0200

    eliminate code duplication of logic in process_cvs_changesets()
    
    Factor out code which is specific to rcsparse and cvsclient into
    separate functions and pass a parameter to process_cvs_changesets()
    so it can decide which of the two needs to be used.
    
    This supersedes the function process_cvs_rlog_changesets() which
    duplicated the looping code also contained in process_cvs_changesets().

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/27/ for more details.