Page MenuHomeSoftware Heritage

Remove remote storage based on `swh.core.api.RPCClient`
ClosedPublic

Authored by aeviso on Sep 15 2021, 4:20 PM.

Details

Reviewers
olasd
douardda
Group Reviewers
Reviewers

Diff Detail

Event Timeline

Build is green

Patch application report for D6272 (id=22706)

Could not rebase; Attempt merge onto 3383cae57e...

Updating 3383cae..e0509cb
Fast-forward
 swh/provenance/__init__.py                     | 21 ++++++++++++++-------
 swh/provenance/api/client.py                   |  2 +-
 swh/provenance/api/server.py                   |  6 +++---
 swh/provenance/cli.py                          |  2 +-
 swh/provenance/origin.py                       | 13 +++++++++++++
 swh/provenance/postgresql/archive.py           | 13 +++++++++++++
 swh/provenance/revision.py                     | 13 +++++++++++++
 swh/provenance/storage/archive.py              | 13 +++++++++++++
 swh/provenance/tests/conftest.py               | 12 ++++++------
 swh/provenance/tests/test_archive_interface.py | 16 ++++++++++++----
 10 files changed, 89 insertions(+), 22 deletions(-)
Changes applied before test
commit e0509cb75b21e7594de55b66818b3d3d663e0dcc
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Sep 15 16:14:10 2021 +0200

    Rename remote storage backend classes

commit d0a11a1499839baebf67407314a78029057b606a
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Sep 15 10:52:44 2021 +0200

    Add StatsD support to the main algorithms of the module

commit a8009be206dc1e414a69a708f826266b750b74cd
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Tue Sep 14 15:33:33 2021 +0200

    Add StatsD support to `ArchiveInterface` implementations

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/347/ for more details.

Why the renaming? And it's an RPC API, not REST

Same comment as on the other diff: looks like it is for consistency with the new rabbitmq RPC, but please explain it

Why the renaming? And it's an RPC API, not REST

The renaming is to make is consistent with how all other backends are named. Please pick a name if you don't like this one, but keep in mind that this was a first attempt to conflict resolution that didn't work and will be removed soon (so the name is not really important after all)

Same comment as on the other diff: looks like it is for consistency with the new rabbitmq RPC, but please explain it

I don't understand this comment. To what comment on the "other diff" you refer?

Build is green

Patch application report for D6272 (id=23003)

Rebasing onto 4c087ea0ec...

Current branch diff-target is up to date.
Changes applied before test
commit 6c3071493b5d3f187113493275d402a27866da95
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Sep 15 16:14:10 2021 +0200

    Rename remote storage backend classes
    
    Make names consistent with the naming convention used for other components.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/360/ for more details.

douardda added a subscriber: douardda.

as @olasd should be squashed, but meh

This revision is now accepted and ready to land.Fri, Oct 1, 2:32 PM
aeviso retitled this revision from Rename remote storage backend classes to Remove remote storage based on `swh.core.api.RPCClient`.Mon, Oct 4, 3:40 PM

Build is green

Patch application report for D6272 (id=23264)

Rebasing onto 4c087ea0ec...

Current branch diff-target is up to date.
Changes applied before test
commit 68c54032460a8f9b97b48417404e910e88a84328
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Sep 15 16:14:10 2021 +0200

    Remove remote provenance storage based on `swh.core.api.RPCClient`
    
    This implementation was a first attempt for conflict resolution that didn't worked as expected.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/415/ for more details.

Build is green

Patch application report for D6272 (id=23266)

Rebasing onto 4c087ea0ec...

Current branch diff-target is up to date.
Changes applied before test
commit 172e327c25883bee768a9c16b850ce6aab7e2eb2
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Wed Sep 15 16:14:10 2021 +0200

    Remove remote provenance storage based on `swh.core.api.RPCClient`
    
    This implementation was a first attempt for conflict resolution that didn't worked as expected.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/417/ for more details.