Update:

• address @ardumont comments
• add CLI section in swh-auth documentation

A fundraising campaign can now be easily created and configured from the WP admin dashboard, closing this.

Looks good to me !

Looks good but some code could be deduplicated before landing this. I also forgot to tell you during last review that we must update copyright headers years when modifying source files (see inline comments).

Looks good to me except I have a doubt on a parameter type (see inline comment). I will accept the diff after it has been checked.

Looks good to me, thanks ! There is still a typo remaining on an exception name, see inline comment.

I added a couple of comments to handle and we should be able to land this afterwards.

Close to a first guided tour draft to be deployed for staff and ambassador reviews.

Update:

• Improve js code coverage
• Add login step to homepage tour

Looks good to me ! Thanks, the save code now handling code definitely needed some cleanup after all those years.

Looks good to me ! Time to tag swh-storage in order for the build to succeed.

Great, thanks !

Update:

• Rebase
• Reorganize code
• Restrict guided tour launch to staff and ambassador users
• Add cypress tests
• Comment code

Looks good to me, thanks !

Thanks !

In T3127#66673, @ardumont wrote:

I guess the cli to update metrics is executed periodically in production ?

I don't think that they are yet but that just got a priority increase now ;)

In D5883#151415, @KShivendu wrote:

Can you also please also take care of updating it at the same time?

Sure. I just created D5912

Also @vlorentz and @vsellier should validate the review too as they are your official GSOC mentors.

Both of them have already reviewed this diff.

The existing scheduler metrics are probably not complete enough for all we want to display (we should review them so they are), but the swh.scheduler journal client already gathers all the information needed, so we > should be able to compute all that we need from the scheduler tables.

After more thoughts about all those metrics, we could revamp the coverage widget into two tabs:

• one tab displaying metrics about loaded origins with detailed counts by forge and links to search interface to browse them
• one tab displaying metrics about listed origins from the data extracted from the scheduler database

In T3127#66665, @ardumont wrote:

@anlambert @rdicosmo

For information, discussing with @olasd, he reminded me that we had already a cli entrypoint [1]
to compute stats about what we want scheduler side.

What's missing implementation wise would be to expose an endpoint to actually display said information.

So, the question is, even though the implementation swh.counter started, do we really want that there
or this ^ scheduler side would be enough?

[1] https://forge.softwareheritage.org/source/swh-scheduler/browse/master/swh/scheduler/cli/origin.py$148-182

@KShivendu, code looks good to me now. Before landing this, you should squash all commits into a single one and improve commit message style following that guide.

In D5883#151341, @ardumont wrote:

Is it okay if I add .vscode in .gitignore. It often gets included by mistake. swh-indexer, swh-storage and swh-web already have it in their .gitignore files.

I guess it's fine if it's already in other modules.
And we should also add it in the .gitignore template repository [1].
Can you also please also take care of updating it at the same time?

[1] https://forge.softwareheritage.org/source/swh-py-template/

Rebase

Remove no longer used constant

Rebase

Rebase

In T3127#66631, @rdicosmo wrote:

Nice to see this moving forward!

These entries in the counter log look suspicious, though, they are not origins:

b'atlassian@bitbucket.org' 2
b'taylorhakes@github.com' 2
b'bunnyhero@bitbucket.org' 1
b'dtrebbien@bitbucket.org' 1
b'eldargab@github.com' 1
b'git@github.com' 1
b'schierlm@git.code.sf.net' 1
b'tomakehurst@github.com' 1
b'wenshao@github.com' 1
b'zimbra-mirror@bitbucket.org' 1

Thanks for working on that task ! Feature seems to work as expected but some improvements can be added before landing this (see my inline comments).

Regarding this, to ease the mapping between a lister and an instance name, we may want to rework the instance names in the scheduler
model (listers table) so that the value is actually the netloc of the origin.

After some analysis, the data we need to properly implement this are:

• the set of lister names and their instance names in order to organize origins by forge types (gitlab, cgit, sourceforge, ...)
• a precise or estimated count for the origins listed by a given lister instance

Almost there ! Some minor changes can still be added before landing this. Regarding my comment about the painless script formatting, it can be handled in another diff.

Looks good to me !

Update:

• Put guided tour steps in a YAML file to ease writing of help texts
• Add homepage guided tour